From add21ba952271c8512ba28a9157c29bef0dab76d Mon Sep 17 00:00:00 2001 From: Jason Blais Date: Wed, 30 Nov 2016 20:36:49 -0500 Subject: [PATCH 01/16] release-3.5 changelog --- CHANGELOG.md | 101 ++++++++++++++++++++++++++++++++------------------- 1 file changed, 63 insertions(+), 38 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9de8e25d..c94d7534 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,53 +1,78 @@ # Mattermost Desktop Application Changelog -## UNDER DEVELOPMENT +## Release v3.5.0 -The "UNDER DEVELOPMENT" section of the Mattermost Desktop changelog appears in the product's `master` branch -to note key changes committed to `master` and are on their way to the next stable release. -When a stable release is pushed, "UNDER DEVELOPMENT" heading is removed from the final changelog of the release. - -Release date: TBD +Release date: December 14, 2016 ### Improvements - - "Cannot connect to Mattermost" is now on top of the page - - Suppressed verbose error which is related to certificates - - Clear cache on desktop app update: The application cache will be purged whenever the desktop app version changes - - Added CTRL+SHIFT+MINUS as a shortcut for zooming out - - Show URL when the mouse cursor is hovering over links #### Windows - - Copying a links address and pasting it inside the app now works - -#### macOS + - URL address is shown when hovering over links with a mouse + - Link addresses can now be copied and pasted inside the app + - Added `CTRL+SHIFT+MINUS` as a shortcut for decreasing font size (zooming out) + - Reduce upgrade issues by properly clearing cache when updating the desktop app to a new version (the application cache will be purged whenever the desktop app version changes) + - When disconnected from Mattermost, the "Cannot connect to Mattermost" page is now properly aligned at the top of the window + - Suppressed verbose errors related to certificates + +#### Mac + - URL address is shown when hovering over links with a mouse + - Added `CTRL+SHIFT+MINUS` as a shortcut for decreasing font size (zooming out) + - Reduce upgrade issues by properly clearing cache when updating the desktop app to a new version (the application cache will be purged whenever the desktop app version changes) + - When disconnected from Mattermost, the "Cannot connect to Mattermost" page is now properly aligned at the top of the window + - Suppressed verbose errors related to certificates #### Linux (Beta) - -### Bug Fixes - - Fixed wrong cursor for "Edit" and "Remove" in Setting page - - Fixed an issue where "Zoom in/out" does not properly work - - YouTube preview works, even if mixed content is allowed + - URL address is shown when hovering over links with a mouse + - Added `CTRL+SHIFT+MINUS` as a shortcut for decreasing font size (zooming out) + - Reduce upgrade issues by properly clearing cache when updating the desktop app to a new version (the application cache will be purged whenever the desktop app version changes) + - When disconnected from Mattermost, the "Cannot connect to Mattermost" page is now properly aligned at the top of the window + - Suppressed verbose errors related to certificates #### Windows - - The accelerator of "Redo" is now shown as `Ctrl+Y` - -#### macOS + - YouTube previews now work, even if mixed content is allowed + - Fixed an incorrect cursor mode for "Edit" and "Remove" buttons on the Settings page + - Fixed an issue where "Zoom in/out" settings did not properly work + +#### Mac + - YouTube previews now work, even if mixed content is allowed - Fixed an issue where the default download folder was `Macintosh HD` - - Removed the unexpected "Show Tab Bar" menu item on macOS 10.12 + - Removed an unexpected "Show Tab Bar" menu item on Mac 10.12 + - Fixed an incorrect cursor mode for "Edit" and "Remove" buttons on the Settings page + - Fixed an issue where "Zoom in/out" settings did not properly work #### Linux (Beta) + - YouTube previews now work, even if mixed content is allowed - Fixed an issue where the option "Leave app running in notification area when the window is closed" was never enabled. + - Fixed an incorrect cursor mode for "Edit" and "Remove" buttons on the Settings page + - Fixed an issue where "Zoom in/out" settings did not properly work -### New Known Issues -This part should be merged with "Known Issues" when releasing new version. - - - "Zoom in/out" does not properly work when the tab bar has focus +### Known Issues #### Windows - - The vertical position of mouse cursor is randomly incorrect when using DPI of 150% + - [If you click twice on the tab bar, and then attempt to use the "Zoom in/out" to change font size, the app window doesn't render properly](https://github.com/mattermost/desktop/issues/334) + - [Direct messages cause notification icons to appear on each team on the tab bar, which don't clear until you click on each team](https://github.com/mattermost/desktop/issues/160) + - [After right-clicking an image or a link, the "Copy Link" option sometimes moves around when clicking different places afterwards](https://github.com/mattermost/desktop/issues/340) + - The vertical position of the mouse cursor is randomly incorrect if you use a DPI print resolution of 150% + - [Windows 7] [Sometimes the app tries to render the page inside the app instead of in a new browser tab when clicking links](https://github.com/mattermost/desktop/issues/369) -#### OS X +#### Mac + - [If you click twice on the tab bar, and then attempt to use the "Zoom in/out" to change font size, the app window doesn't render properly](https://github.com/mattermost/desktop/issues/334) + - [Direct messages cause notification icons to appear on each team on the tab bar, which don't clear until you click on each team](https://github.com/mattermost/desktop/issues/160) + - [After right-clicking an image or a link, the "Copy Link" option sometimes moves around when clicking different places afterwards](https://github.com/mattermost/desktop/issues/340) + - [After uploading a file with a keyboard shortcut, focus isn't set back to the message box](https://github.com/mattermost/desktop/issues/341) -#### Linux +#### Linux (Beta) + - [If you click twice on the tab bar, and then attempt to use the "Zoom in/out" to change font size, the app window doesn't render properly](https://github.com/mattermost/desktop/issues/334) + - [Direct messages cause notification icons to appear on each team on the tab bar, which don't clear until you click on each team](https://github.com/mattermost/desktop/issues/160) + - [After right-clicking an image or a link, the "Copy Link" option sometimes moves around when clicking different places afterwards](https://github.com/mattermost/desktop/issues/340) + - [Ubuntu - 64 bit] Right clicking taskbar icon and choosing **Quit** only minimizes the app + - [Ubuntu - 64 bit] [Direct message notification comes as a streak of line instead of a pop up](https://github.com/mattermost/platform/issues/3589) + +### Contributors + +Many thanks to all our contributors. In alphabetical order: + +- [itsmartin](https://github.com/itsmartin), [jasonblais](https://github.com/jasonblais), [jcomack](https://github.com/jcomack), [jnugh](https://github.com/jnugh), [kytwb](https://github.com/kytwb), [magicmonty](https://github.com/magicmonty), [Razzeee](https://github.com/Razzeee), [yuya-oc](https://github.com/yuya-oc) ---- @@ -57,7 +82,7 @@ Release date: September 30, 2016 ### Bug Fixes -#### OS X +#### Mac - Fixed an issue where the app window pops up second to foreground when a new message is received ---- @@ -86,7 +111,7 @@ Version number updated to 3.4 to make numbering consistent with Mattermost serve - The app now tries to reconnect periodically if a page fails to load - Only one instance of the desktop application will now load at a time -#### OS X +#### Mac - Current team and channel name shown in window title bar - Team tab is bolded for unread messages and has a red dot with a count of unread mentions - Added an option to configure whether a red badge is shown on taskbar icon for unread messages @@ -129,7 +154,7 @@ Version number updated to 3.4 to make numbering consistent with Mattermost serve - Fixed an issue where application icon at the top left of the window was pixelated - Fixed an issue where the application kept focus after closing the app window -#### OS X +#### Mac - Cut, copy and paste are shown in the user interface only when the commands are available - Copying link addresses now work properly - Saving images by right-clicking the image preview now works @@ -153,7 +178,7 @@ Version number updated to 3.4 to make numbering consistent with Mattermost serve - Copying a link address and pasting it inside the app doesn't work - YouTube videos do not work if mixed content is enabled from app settings -#### OS X +#### Mac - YouTube videos do not work if mixed content is enabled from app settings #### Linux @@ -187,7 +212,7 @@ Release date: 2016-07-18 - Added auto-reloading when tab fails to load the team. - Added the ability to access all of your teams by right clicking the system tray icon. -#### OS X +#### Mac - Added colored badges to the menu icon when there are unread channels/mentions. - Added an option to minimize the app to the system tray when application window is closed. - Added auto-reloading when tab fails to load the team. @@ -234,7 +259,7 @@ Release date: 2016-07-18 - Fixed the blurred system tray icon. - Fixed a redundant description appearing in the pinned start menu on Windows 7. -#### OS X +#### Mac - Fixed two icons appearing on a notification. ### Known Issues @@ -259,7 +284,7 @@ Many thanks to all our contributors. In alphabetical order: ### Improvements - Added a dialog to confirm use of non-http(s) protocols prior to opening links. For example, clicking on a link to `file://test` will open a dialog to confirm the user intended to open a file. -#### Windows and OS X +#### Windows and Mac - Added a right-click menu option for tray icon to open the Desktop application on Windows and OS X. ### Known issues @@ -286,7 +311,7 @@ This release contains a security update and it is highly recommended that users - Add **Allow mixed content** option to render images with `http://`. - Add the login dialog for http authentication. -#### OS X +#### Mac - Add the option to show the icon on menu bar. #### Linux From 95dcbf794156e97141ec84cb8c5360c327514011 Mon Sep 17 00:00:00 2001 From: Jason Blais Date: Thu, 1 Dec 2016 09:45:01 -0500 Subject: [PATCH 02/16] Update CHANGELOG.md --- CHANGELOG.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c94d7534..2b09c890 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,7 +16,7 @@ Release date: December 14, 2016 #### Mac - URL address is shown when hovering over links with a mouse - - Added `CTRL+SHIFT+MINUS` as a shortcut for decreasing font size (zooming out) + - Added `CMD+SHIFT+MINUS` as a shortcut for decreasing font size (zooming out) - Reduce upgrade issues by properly clearing cache when updating the desktop app to a new version (the application cache will be purged whenever the desktop app version changes) - When disconnected from Mattermost, the "Cannot connect to Mattermost" page is now properly aligned at the top of the window - Suppressed verbose errors related to certificates @@ -28,15 +28,18 @@ Release date: December 14, 2016 - When disconnected from Mattermost, the "Cannot connect to Mattermost" page is now properly aligned at the top of the window - Suppressed verbose errors related to certificates +### Bug Fixes + #### Windows - YouTube previews now work, even if mixed content is allowed - Fixed an incorrect cursor mode for "Edit" and "Remove" buttons on the Settings page - Fixed an issue where "Zoom in/out" settings did not properly work + - The menu bar option for "Redo" is now properly shown as `CTRL+Y` #### Mac - YouTube previews now work, even if mixed content is allowed - Fixed an issue where the default download folder was `Macintosh HD` - - Removed an unexpected "Show Tab Bar" menu item on Mac 10.12 + - Removed an unexpected "Show Tab Bar" menu item on MacOS 10.12 - Fixed an incorrect cursor mode for "Edit" and "Remove" buttons on the Settings page - Fixed an issue where "Zoom in/out" settings did not properly work From 5642fb51fe6f282ec11f8e092a281aa53cf2de05 Mon Sep 17 00:00:00 2001 From: Jason Blais Date: Thu, 1 Dec 2016 18:08:57 -0500 Subject: [PATCH 03/16] Reduce redundancy in changelog by adding common improvements under "all platforms" subheading --- CHANGELOG.md | 145 +++++++++++++++++---------------------------------- 1 file changed, 47 insertions(+), 98 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2b09c890..c2977f2c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,68 +6,49 @@ Release date: December 14, 2016 ### Improvements -#### Windows +#### All Platforms - URL address is shown when hovering over links with a mouse - Link addresses can now be copied and pasted inside the app - Added `CTRL+SHIFT+MINUS` as a shortcut for decreasing font size (zooming out) - Reduce upgrade issues by properly clearing cache when updating the desktop app to a new version (the application cache will be purged whenever the desktop app version changes) - When disconnected from Mattermost, the "Cannot connect to Mattermost" page is now properly aligned at the top of the window - - Suppressed verbose errors related to certificates - -#### Mac - - URL address is shown when hovering over links with a mouse - - Added `CMD+SHIFT+MINUS` as a shortcut for decreasing font size (zooming out) - - Reduce upgrade issues by properly clearing cache when updating the desktop app to a new version (the application cache will be purged whenever the desktop app version changes) - - When disconnected from Mattermost, the "Cannot connect to Mattermost" page is now properly aligned at the top of the window - - Suppressed verbose errors related to certificates + - Suppressed error messages when launching the app from the command line and `certificate.json` is missing in the user data directory -#### Linux (Beta) - - URL address is shown when hovering over links with a mouse - - Added `CTRL+SHIFT+MINUS` as a shortcut for decreasing font size (zooming out) - - Reduce upgrade issues by properly clearing cache when updating the desktop app to a new version (the application cache will be purged whenever the desktop app version changes) - - When disconnected from Mattermost, the "Cannot connect to Mattermost" page is now properly aligned at the top of the window - - Suppressed verbose errors related to certificates +#### Windows + - Link addresses can now be copied and pasted inside the app ### Bug Fixes -#### Windows +#### All Platforms - YouTube previews now work, even if mixed content is allowed - Fixed an incorrect cursor mode for "Edit" and "Remove" buttons on the Settings page - Fixed an issue where "Zoom in/out" settings did not properly work + +#### Windows - The menu bar option for "Redo" is now properly shown as `CTRL+Y` #### Mac - - YouTube previews now work, even if mixed content is allowed - Fixed an issue where the default download folder was `Macintosh HD` - Removed an unexpected "Show Tab Bar" menu item on MacOS 10.12 - - Fixed an incorrect cursor mode for "Edit" and "Remove" buttons on the Settings page - - Fixed an issue where "Zoom in/out" settings did not properly work #### Linux (Beta) - - YouTube previews now work, even if mixed content is allowed - Fixed an issue where the option "Leave app running in notification area when the window is closed" was never enabled. - - Fixed an incorrect cursor mode for "Edit" and "Remove" buttons on the Settings page - - Fixed an issue where "Zoom in/out" settings did not properly work ### Known Issues -#### Windows +#### All Platforms - [If you click twice on the tab bar, and then attempt to use the "Zoom in/out" to change font size, the app window doesn't render properly](https://github.com/mattermost/desktop/issues/334) - [Direct messages cause notification icons to appear on each team on the tab bar, which don't clear until you click on each team](https://github.com/mattermost/desktop/issues/160) - [After right-clicking an image or a link, the "Copy Link" option sometimes moves around when clicking different places afterwards](https://github.com/mattermost/desktop/issues/340) + +#### Windows - The vertical position of the mouse cursor is randomly incorrect if you use a DPI print resolution of 150% - [Windows 7] [Sometimes the app tries to render the page inside the app instead of in a new browser tab when clicking links](https://github.com/mattermost/desktop/issues/369) #### Mac - - [If you click twice on the tab bar, and then attempt to use the "Zoom in/out" to change font size, the app window doesn't render properly](https://github.com/mattermost/desktop/issues/334) - - [Direct messages cause notification icons to appear on each team on the tab bar, which don't clear until you click on each team](https://github.com/mattermost/desktop/issues/160) - - [After right-clicking an image or a link, the "Copy Link" option sometimes moves around when clicking different places afterwards](https://github.com/mattermost/desktop/issues/340) - [After uploading a file with a keyboard shortcut, focus isn't set back to the message box](https://github.com/mattermost/desktop/issues/341) #### Linux (Beta) - - [If you click twice on the tab bar, and then attempt to use the "Zoom in/out" to change font size, the app window doesn't render properly](https://github.com/mattermost/desktop/issues/334) - - [Direct messages cause notification icons to appear on each team on the tab bar, which don't clear until you click on each team](https://github.com/mattermost/desktop/issues/160) - - [After right-clicking an image or a link, the "Copy Link" option sometimes moves around when clicking different places afterwards](https://github.com/mattermost/desktop/issues/340) - [Ubuntu - 64 bit] Right clicking taskbar icon and choosing **Quit** only minimizes the app - [Ubuntu - 64 bit] [Direct message notification comes as a streak of line instead of a pop up](https://github.com/mattermost/platform/issues/3589) @@ -100,92 +81,62 @@ Version number updated to 3.4 to make numbering consistent with Mattermost serve ### Improvements -#### Windows +#### All Platforms - Current team and channel name shown in window title bar - Team tab is bolded for unread messages and has a red dot with a count of unread mentions - - Added an option to configure whether a red badge is shown on taskbar icon for unread messages - Added new shortcuts: - - `CTRL + S`: sets focus on the Mattermost search box - - `ALT + Left Arrow`: go to previous page in history - - `ALT + Right Arrow`: go to next page in history + - `CTRL+S`; `CMD+S` on Mac: sets focus on the Mattermost search box + - `ALT+Left Arrow`; `CMD+[` on Mac: go to previous page in history + - `ALT+Right Arrow`; `CMD+]` on Mac: go to next page in history - Upgraded the Settings page user interface - - Added access to the settings menu from the system tray icon - - Added validation for name and URL when adding a new team on the Settings page - The app now tries to reconnect periodically if a page fails to load + - Added validation for name and URL when adding a new team on the Settings page + +#### Windows + - Added access to the settings menu from the system tray icon - Only one instance of the desktop application will now load at a time + - Added an option to configure whether a red badge is shown on taskbar icon for unread messages #### Mac - - Current team and channel name shown in window title bar - - Team tab is bolded for unread messages and has a red dot with a count of unread mentions - Added an option to configure whether a red badge is shown on taskbar icon for unread messages - - Added new shortcuts: - - `CMD + S`: sets focus on the Mattermost search box - - `CMD + [`: go to previous page in history - - `CMD + ]`: go to next page in history - - Upgraded the Settings page user interface - - The app now tries to reconnect periodically if a page fails to load - - Added validation for name and URL when adding a new team on the Settings page #### Linux (Beta) - - Current team and channel name shown in window title bar - - Team tab is bolded for unread messages and has a red dot with a count of unread mentions - Added an option to flash taskbar icon when a new message is received - Added a badge to count mentions on the taskbar icon (for Unity) - Added a script, `create_desktop_file.sh` to create `Mattermost.desktop` desktop entry to help [integrate the application into a desktop environment](https://wiki.archlinux.org/index.php/Desktop_entries) more easily - - Added new shortcuts: - - `CTRL + S`: sets focus on the Mattermost search box - - `ALT + Left Arrow`: go to previous page in history - - `ALT + Right Arrow`: go to next page in history - - Upgraded the Settings page user interface - Added access to the settings menu from the system tray icon - - The app now tries to reconnect periodically if a page fails to load - - Added validation for name and URL when adding a new team on the Settings page - Only one instance of the desktop application will now load at a time ### Bug Fixes -#### Windows +#### All Platforms - Cut, copy and paste are shown in the user interface only when the commands are available - Copying link addresses now work properly - Saving images by right-clicking the image preview now works - Refreshing the app page no longer takes you to the team selection page, but keeps you on the current channel + - Fixed an issue where the maximized state of the app window was lost in some cases + - Fixed an issue where shortcuts didn't work when switching applications or tabs in some cases + +#### Windows - Removed misleading shortcuts from the system tray menu - Removed unclear desktop notifications when the application page fails to load - Fixed the Mattermost icon for desktop notifications in Windows 10 - - Fixed an issue where the maximized state of the app window was lost in some cases - - Fixed an issue where shortcuts didn't work when switching applications or tabs in some cases - Fixed an issue where application icon at the top left of the window was pixelated - Fixed an issue where the application kept focus after closing the app window -#### Mac - - Cut, copy and paste are shown in the user interface only when the commands are available - - Copying link addresses now work properly - - Saving images by right-clicking the image preview now works - - Refreshing the app page no longer takes you to the team selection page, but keeps you on the current channel - - Fixed an issue where the maximized state of the app window was lost in some cases - - Fixed an issue where shortcuts didn't work when switching applications or tabs in some cases - #### Linux (Beta) - - Cut, copy and paste are shown in the user interface only when the commands are available - - Copying link addresses now work properly - - Saving images by right-clicking the image preview now works - - Refreshing the app page no longer takes you to the team selection page, but keeps you on the current channel - Removed misleading shortcuts from the system tray menu - Removed unclear desktop notifications when the application page fails to load - - Fixed an issue where the maximized state of the app window was lost in some cases - - Fixed an issue where shortcuts didn't work when switching applications or tabs in some cases ### Known Issues +#### All Platforms + - YouTube videos do not work if mixed content is enabled from app settings + #### Windows - Copying a link address and pasting it inside the app doesn't work - - YouTube videos do not work if mixed content is enabled from app settings - -#### Mac - - YouTube videos do not work if mixed content is enabled from app settings #### Linux - - YouTube videos do not work if mixed content is enabled from app settings - [Ubuntu - 64 bit] Right clicking taskbar icon and choosing **Quit** only minimizes the app - [Ubuntu - 64 bit] [Direct message notification comes as a streak of line instead of a pop up](https://github.com/mattermost/platform/issues/3589) @@ -205,30 +156,11 @@ Release date: 2016-07-18 ### Improvements -#### Windows -- Added an installer for better install experience. -- The app now minimizes to the system tray when application window is closed. -- Added an option to launch application on login. -- Added an option to blink the taskbar icon when a new message has arrived. -- Added tooltip text for the system tray icon in order to show count of unread channels/mentions. -- Added an option to toggle the app to minimize/restore when clicking on the system tray icon. +#### All Platforms - Added auto-reloading when tab fails to load the team. - Added the ability to access all of your teams by right clicking the system tray icon. -#### Mac -- Added colored badges to the menu icon when there are unread channels/mentions. -- Added an option to minimize the app to the system tray when application window is closed. -- Added auto-reloading when tab fails to load the team. -- Added the ability to access all of your teams by right clicking the system tray icon. - -#### Linux (Beta) -- Added an option to show the icon on menu bar (requires libappindicator1 on Ubuntu). -- Added an option to launch application on login. -- Added an option to minimize the app to the system tray when application window is closed. -- Added auto-reloading when tab fails to load the team. -- Added the ability to access all of your teams by right clicking the system tray icon. - -#### Menu Bar +##### Menu Bar - New Keyboard Shortcuts - Adjust text size - Ctrl+0 (Menu Bar -> View -> Actual Size): Reset the zoom level. @@ -246,10 +178,27 @@ Release date: 2016-07-18 - Link to [**Mattermost Docs**](docs.mattermost.com) - Field to indicate the application version number. -#### Settings Page +##### Settings Page - Added a "+" button next to the **Teams** label, which allows you to add more teams. - Added the ability to edit team information by clicking on the pencil icon to the right of the team name. +#### Windows +- Added an installer for better install experience. +- The app now minimizes to the system tray when application window is closed. +- Added an option to launch application on login. +- Added an option to blink the taskbar icon when a new message has arrived. +- Added tooltip text for the system tray icon in order to show count of unread channels/mentions. +- Added an option to toggle the app to minimize/restore when clicking on the system tray icon. + +#### Mac +- Added colored badges to the menu icon when there are unread channels/mentions. +- Added an option to minimize the app to the system tray when application window is closed. + +#### Linux (Beta) +- Added an option to show the icon on menu bar (requires libappindicator1 on Ubuntu). +- Added an option to launch application on login. +- Added an option to minimize the app to the system tray when application window is closed. + ### Other Changes - Application license changed from MIT License to Apache License, Version 2.0. From 9ce019acd6c59fbe6993ddc6fec52554b6e76906 Mon Sep 17 00:00:00 2001 From: Yuya Ochiai Date: Mon, 5 Dec 2016 20:38:01 +0900 Subject: [PATCH 04/16] Add some fixes for CHANGELOG.md --- CHANGELOG.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c2977f2c..e048afd4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,10 +26,10 @@ Release date: December 14, 2016 #### Windows - The menu bar option for "Redo" is now properly shown as `CTRL+Y` - + #### Mac - Fixed an issue where the default download folder was `Macintosh HD` - - Removed an unexpected "Show Tab Bar" menu item on MacOS 10.12 + - Removed an unexpected "Show Tab Bar" menu item on macOS 10.12 #### Linux (Beta) - Fixed an issue where the option "Leave app running in notification area when the window is closed" was never enabled. @@ -39,17 +39,17 @@ Release date: December 14, 2016 #### All Platforms - [If you click twice on the tab bar, and then attempt to use the "Zoom in/out" to change font size, the app window doesn't render properly](https://github.com/mattermost/desktop/issues/334) - [Direct messages cause notification icons to appear on each team on the tab bar, which don't clear until you click on each team](https://github.com/mattermost/desktop/issues/160) - - [After right-clicking an image or a link, the "Copy Link" option sometimes moves around when clicking different places afterwards](https://github.com/mattermost/desktop/issues/340) + - [After right-clicking an image or a link, the "Copy Link" option sometimes moves around when clicking different places afterwards](https://github.com/mattermost/desktop/issues/340) #### Windows - - The vertical position of the mouse cursor is randomly incorrect if you use a DPI print resolution of 150% + - [The vertical position of the mouse cursor is randomly incorrect if you use a DPI print resolution of 150%](https://github.com/mattermost/desktop/pull/307#issuecomment-251980757) - [Windows 7] [Sometimes the app tries to render the page inside the app instead of in a new browser tab when clicking links](https://github.com/mattermost/desktop/issues/369) #### Mac - [After uploading a file with a keyboard shortcut, focus isn't set back to the message box](https://github.com/mattermost/desktop/issues/341) #### Linux (Beta) - - [Ubuntu - 64 bit] Right clicking taskbar icon and choosing **Quit** only minimizes the app + - [Ubuntu - 64 bit] [Right clicking taskbar icon and choosing **Quit** only minimizes the app](https://github.com/mattermost/desktop/issues/90#issuecomment-233712183) - [Ubuntu - 64 bit] [Direct message notification comes as a streak of line instead of a pop up](https://github.com/mattermost/platform/issues/3589) ### Contributors From 0d2b08c9e8b1a134901cf1eda7ec4e2cd426278f Mon Sep 17 00:00:00 2001 From: Yuya Ochiai Date: Mon, 5 Dec 2016 23:10:21 +0900 Subject: [PATCH 05/16] Fix Exec of .desktop file --- resources/linux/create_desktop_file.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/linux/create_desktop_file.sh b/resources/linux/create_desktop_file.sh index 3eb06b7d..3241c30f 100755 --- a/resources/linux/create_desktop_file.sh +++ b/resources/linux/create_desktop_file.sh @@ -9,7 +9,7 @@ cat < Mattermost.desktop [Desktop Entry] Name=Mattermost Comment=Mattermost Desktop application for Linux -Exec="${FULL_PATH}/Mattermost" +Exec="${FULL_PATH}/mattermost-desktop" Terminal=false Type=Application Icon=${FULL_PATH}/icon.png From c6fa55dd7c5fa3079e2b821eed5d876954ecd956 Mon Sep 17 00:00:00 2001 From: Yuya Ochiai Date: Mon, 5 Dec 2016 23:45:35 +0900 Subject: [PATCH 06/16] Add simple README for Linux packages --- package.json | 2 +- resources/linux/README.md | 74 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 75 insertions(+), 1 deletion(-) create mode 100644 resources/linux/README.md diff --git a/package.json b/package.json index 5206979b..1986fa08 100644 --- a/package.json +++ b/package.json @@ -76,7 +76,7 @@ }, { "from": "resources/linux", - "filter": "create_desktop_file.sh" + "filter": ["create_desktop_file.sh", "README.md"] } ] }, diff --git a/resources/linux/README.md b/resources/linux/README.md new file mode 100644 index 00000000..4944e86a --- /dev/null +++ b/resources/linux/README.md @@ -0,0 +1,74 @@ +# Mattermost Desktop for Linux + +## Table of Contents + +- [Install](#install) +- [Usage](#usage) +- [Contributing](#contributing) +- [License](#license) + + +## Install + +If you were installed the application via package managers, you don't have to do +anymore. It's ready to use in your system, so please follow [usage](#usage) +instruction. + +First, locate the extracted directory into your desired directory (e.g. +`/opt/mattermost-desktop-`). + + +### Desktop launcher + +Execute the script file to create `Mattermost.desktop` file. + +``` +/opt/mattermost-desktop-/create_desktop_file.sh +``` + +Then move it into appropreate directory of your desktop environment. For +example, it's `~/.local/share/applications/` for current user on Ubuntu Unity. + +``` +mv Mattermost.desktop ~/.local/share/applications/ +``` + +### Terminal command + +Set `PATH` environment variable to enable launching from terminal. +For example, you can append following line into `~/.bashrc`. + +```sh +# assuming that /opt/mattermost-desktop-/mattermost-desktop is the executable file. +export PATH=$PATH:/opt/mattermost-desktop- +``` + +Alternatively, you can also create a symbolic link for the application. + +```sh +sudo ln -s /opt/mattermost-desktop-/mattermost-desktop /usr/local/bin/ +``` + +## Usage + +After launching, you need to configure the application to interact with your team. + +1. If you don't see "Settings" page, select **File** -> **Settings...** from the menu bar. +2. Click **Add new team** next to the right of Team Management section. +3. Enter **Name** and a valid **URL**, which begins with either `http://` or `https://`. +4. Click **Add**. + + +### More guides + +Available at [Mattermost Documentation](https://docs.mattermost.com/help/apps/desktop-guide.html). + + +## Contributing + +See [the contribute file](https://github.com/mattermost/desktop/blob/master/CONTRIBUTING.md). + + +## License + +Apache Lisence, Version 2.0 From f60d1fe0e4cc2664bec246dfc58132e49ab524b3 Mon Sep 17 00:00:00 2001 From: Yuya Ochiai Date: Tue, 6 Dec 2016 22:06:04 +0900 Subject: [PATCH 07/16] Fix confused cursor in HiDPI https://github.com/electron/electron/issues/7655#issuecomment-259688853 --- src/main.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/main.js b/src/main.js index bf1c0b2f..eef0b6d6 100644 --- a/src/main.js +++ b/src/main.js @@ -64,6 +64,12 @@ const assetsDir = path.resolve(app.getAppPath(), 'assets'); // be closed automatically when the JavaScript object is garbage collected. var mainWindow = null; +// Fix confused cursor in HiDPI +// https://github.com/electron/electron/issues/7655#issuecomment-259688853 +if (process.platform === 'win32') { + app.commandLine.appendSwitch('enable-use-zoom-for-dsf', 'false'); +} + var argv = require('yargs').parse(process.argv.slice(1)); const electronConnect = argv.livereload ? require('electron-connect') : null; From 0ae07b964ef1d8700581388c097f46f806821efa Mon Sep 17 00:00:00 2001 From: Yuya Ochiai Date: Wed, 7 Dec 2016 01:06:59 +0900 Subject: [PATCH 08/16] Fix "Leave app running in notification area" checkbox not working on macOS --- src/browser/components/SettingsPage.jsx | 4 +--- src/common/settings.js | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/browser/components/SettingsPage.jsx b/src/browser/components/SettingsPage.jsx index 0eaeeb2d..08f3e341 100644 --- a/src/browser/components/SettingsPage.jsx +++ b/src/browser/components/SettingsPage.jsx @@ -123,9 +123,7 @@ const SettingsPage = React.createClass({ }); }, handleChangeMinimizeToTray() { - var shouldMinimizeToTray = - (process.platform !== 'darwin' || !this.refs.showTrayIcon.props.checked) && - !this.refs.minimizeToTray.props.checked; + const shouldMinimizeToTray = this.state.showTrayIcon && !this.refs.minimizeToTray.props.checked; this.setState({ minimizeToTray: shouldMinimizeToTray diff --git a/src/common/settings.js b/src/common/settings.js index ac2abf5a..f3905889 100644 --- a/src/common/settings.js +++ b/src/common/settings.js @@ -20,6 +20,7 @@ function loadDefault(version) { showTrayIcon: false, trayIconTheme: '', disablewebsecurity: true, + minimizeToTray: false, toggleWindowOnTrayIconClick: false, version: 1, notifications: { From cad3cb5553ea575ff6508ee2532e971d5c066967 Mon Sep 17 00:00:00 2001 From: Jason Blais Date: Tue, 6 Dec 2016 12:53:47 -0500 Subject: [PATCH 09/16] Update README.md --- resources/linux/README.md | 32 +++++++++++++------------------- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/resources/linux/README.md b/resources/linux/README.md index 4944e86a..678194c9 100644 --- a/resources/linux/README.md +++ b/resources/linux/README.md @@ -3,31 +3,26 @@ ## Table of Contents - [Install](#install) -- [Usage](#usage) +- [User Guide](#user-guide) - [Contributing](#contributing) - [License](#license) ## Install -If you were installed the application via package managers, you don't have to do -anymore. It's ready to use in your system, so please follow [usage](#usage) -instruction. - -First, locate the extracted directory into your desired directory (e.g. -`/opt/mattermost-desktop-`). +If you installed the application via a package manager, it's ready to use in your system. Please follow the [User Guide](#user-guide) for further information. +Otherwise, first locate the extracted directory in your desired directory (e.g. `/opt/mattermost-desktop-`) and follow the steps below. ### Desktop launcher -Execute the script file to create `Mattermost.desktop` file. +Execute the script file to create a `Mattermost.desktop` file. ``` /opt/mattermost-desktop-/create_desktop_file.sh ``` -Then move it into appropreate directory of your desktop environment. For -example, it's `~/.local/share/applications/` for current user on Ubuntu Unity. +Then move it to the appropriate directory of your desktop environment. For example, on Ubuntu Unity it's `~/.local/share/applications/` for the current user. ``` mv Mattermost.desktop ~/.local/share/applications/ @@ -35,8 +30,7 @@ mv Mattermost.desktop ~/.local/share/applications/ ### Terminal command -Set `PATH` environment variable to enable launching from terminal. -For example, you can append following line into `~/.bashrc`. +Set a `PATH` environment variable to enable launching from the terminal. For example, you can append the following line into `~/.bashrc`. ```sh # assuming that /opt/mattermost-desktop-/mattermost-desktop is the executable file. @@ -49,24 +43,24 @@ Alternatively, you can also create a symbolic link for the application. sudo ln -s /opt/mattermost-desktop-/mattermost-desktop /usr/local/bin/ ``` -## Usage +You're now all set! See the [User Guide](#user-guide) below for instructions. + + +## User Guide After launching, you need to configure the application to interact with your team. -1. If you don't see "Settings" page, select **File** -> **Settings...** from the menu bar. +1. If you don't see a page titled "Settings", select **File** > **Settings...** from the menu bar. 2. Click **Add new team** next to the right of Team Management section. 3. Enter **Name** and a valid **URL**, which begins with either `http://` or `https://`. 4. Click **Add**. - -### More guides - -Available at [Mattermost Documentation](https://docs.mattermost.com/help/apps/desktop-guide.html). +More guides are available at [Mattermost Documentation](https://docs.mattermost.com/help/apps/desktop-guide.html). ## Contributing -See [the contribute file](https://github.com/mattermost/desktop/blob/master/CONTRIBUTING.md). +See [contributing guidlines](https://github.com/mattermost/desktop/blob/master/CONTRIBUTING.md) for reporting bugs, features or submitting pull requests. ## License From 39117f9208742a8f1465d332d7b308bb41ebecd4 Mon Sep 17 00:00:00 2001 From: Yuya Ochiai Date: Wed, 7 Dec 2016 20:25:30 +0900 Subject: [PATCH 10/16] Update README.md --- resources/linux/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/resources/linux/README.md b/resources/linux/README.md index 678194c9..303b2686 100644 --- a/resources/linux/README.md +++ b/resources/linux/README.md @@ -54,6 +54,7 @@ After launching, you need to configure the application to interact with your tea 2. Click **Add new team** next to the right of Team Management section. 3. Enter **Name** and a valid **URL**, which begins with either `http://` or `https://`. 4. Click **Add**. +5. Click **Save**. More guides are available at [Mattermost Documentation](https://docs.mattermost.com/help/apps/desktop-guide.html). From 1f71df3b7737fe1c9a0cda66bbbe0534b6e5a007 Mon Sep 17 00:00:00 2001 From: Jason Blais Date: Wed, 7 Dec 2016 08:07:52 -0500 Subject: [PATCH 11/16] Fix typo --- resources/linux/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/linux/README.md b/resources/linux/README.md index 303b2686..0c394f08 100644 --- a/resources/linux/README.md +++ b/resources/linux/README.md @@ -61,7 +61,7 @@ More guides are available at [Mattermost Documentation](https://docs.mattermost. ## Contributing -See [contributing guidlines](https://github.com/mattermost/desktop/blob/master/CONTRIBUTING.md) for reporting bugs, features or submitting pull requests. +See [contributing guidelines](https://github.com/mattermost/desktop/blob/master/CONTRIBUTING.md) for reporting bugs, features or submitting pull requests. ## License From 3bfd688d12828b27030354774a97585ed05e393e Mon Sep 17 00:00:00 2001 From: Yuya Ochiai Date: Thu, 8 Dec 2016 00:10:29 +0900 Subject: [PATCH 12/16] Fix typo --- resources/linux/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/linux/README.md b/resources/linux/README.md index 0c394f08..3f4d42f0 100644 --- a/resources/linux/README.md +++ b/resources/linux/README.md @@ -66,4 +66,4 @@ See [contributing guidelines](https://github.com/mattermost/desktop/blob/master/ ## License -Apache Lisence, Version 2.0 +Apache License, Version 2.0 From 5ca61680002d446533ff8ba37402b346287b8285 Mon Sep 17 00:00:00 2001 From: Jason Blais Date: Thu, 8 Dec 2016 14:59:42 -0500 Subject: [PATCH 13/16] Update CHANGELOG.md --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e048afd4..10760879 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -42,7 +42,6 @@ Release date: December 14, 2016 - [After right-clicking an image or a link, the "Copy Link" option sometimes moves around when clicking different places afterwards](https://github.com/mattermost/desktop/issues/340) #### Windows - - [The vertical position of the mouse cursor is randomly incorrect if you use a DPI print resolution of 150%](https://github.com/mattermost/desktop/pull/307#issuecomment-251980757) - [Windows 7] [Sometimes the app tries to render the page inside the app instead of in a new browser tab when clicking links](https://github.com/mattermost/desktop/issues/369) #### Mac From 82f6dbee4adde8ec96a3e3160a1a7f7d2f0840f2 Mon Sep 17 00:00:00 2001 From: Yuya Ochiai Date: Sun, 11 Dec 2016 01:52:58 +0900 Subject: [PATCH 14/16] Update Electron to 1.4.12 Certificate Transparency Fix http://electron.atom.io/blog/2016/12/09/certificate-transparency-fix --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 1986fa08..27f7b1f7 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "chai-as-promised": "^5.3.0", "cross-env": "^3.1.2", "devtron": "^1.3.0", - "electron": "1.4.6", + "electron": "1.4.12", "electron-builder": "^7.11.2", "electron-connect": "~0.6.0", "eslint": "^3.4.0", From 89e3a52ef232b78593419fa605f988fe2f2af21d Mon Sep 17 00:00:00 2001 From: Jonas Schwabe Date: Sat, 10 Dec 2016 20:32:04 +0100 Subject: [PATCH 15/16] Add a fallback when the notification icon theme is not valid - the app did not start up successfully before --- src/main.js | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/main.js b/src/main.js index eef0b6d6..283aca7e 100644 --- a/src/main.js +++ b/src/main.js @@ -153,12 +153,21 @@ const trayImages = (() => { } case 'linux': { - const theme = config.trayIconTheme || 'light'; - return { - normal: nativeImage.createFromPath(path.resolve(assetsDir, 'linux', theme, 'MenuIconTemplate.png')), - unread: nativeImage.createFromPath(path.resolve(assetsDir, 'linux', theme, 'MenuIconUnreadTemplate.png')), - mention: nativeImage.createFromPath(path.resolve(assetsDir, 'linux', theme, 'MenuIconMentionTemplate.png')) - }; + const theme = config.trayIconTheme; + try { + return { + normal: nativeImage.createFromPath(path.resolve(assetsDir, 'linux', theme, 'MenuIconTemplate.png')), + unread: nativeImage.createFromPath(path.resolve(assetsDir, 'linux', theme, 'MenuIconUnreadTemplate.png')), + mention: nativeImage.createFromPath(path.resolve(assetsDir, 'linux', theme, 'MenuIconMentionTemplate.png')) + }; + } catch (e) { + //Fallback for invalid theme setting + return { + normal: nativeImage.createFromPath(path.resolve(assetsDir, 'linux', 'light', 'MenuIconTemplate.png')), + unread: nativeImage.createFromPath(path.resolve(assetsDir, 'linux', 'light', 'MenuIconUnreadTemplate.png')), + mention: nativeImage.createFromPath(path.resolve(assetsDir, 'linux', 'light', 'MenuIconMentionTemplate.png')) + }; + } } default: return {}; From d4f3ca23d3f0ada5d6ef70b26adf1b0bb5ec3d39 Mon Sep 17 00:00:00 2001 From: Jonas Schwabe Date: Sat, 10 Dec 2016 20:27:09 +0100 Subject: [PATCH 16/16] Fixes a bug on the settings pane which rendered the notification theme icon as a checkbox --- src/browser/components/SettingsPage.jsx | 28 ++++++++++++++----------- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/src/browser/components/SettingsPage.jsx b/src/browser/components/SettingsPage.jsx index 08f3e341..c4509dfa 100644 --- a/src/browser/components/SettingsPage.jsx +++ b/src/browser/components/SettingsPage.jsx @@ -1,5 +1,6 @@ const React = require('react'); -const {Button, Checkbox, Col, FormGroup, Grid, Navbar, Row} = require('react-bootstrap'); +const ReactDOM = require('react-dom'); +const {Button, Checkbox, Col, FormGroup, FormControl, ControlLabel, Grid, Navbar, Row} = require('react-bootstrap'); const {ipcRenderer, remote} = require('electron'); const AutoLaunch = require('auto-launch'); @@ -114,7 +115,7 @@ const SettingsPage = React.createClass({ }, handleChangeTrayIconTheme() { this.setState({ - trayIconTheme: !this.refs.trayIconTheme.props.checked + trayIconTheme: ReactDOM.findDOMNode(this.refs.trayIconTheme).value }); }, handleChangeAutoStart() { @@ -189,16 +190,19 @@ const SettingsPage = React.createClass({ } if (process.platform === 'linux') { options.push( - {'Icon theme (Need to restart the application)'} - - - ); + + {'Icon theme (Need to restart the application)'} + + + + + ); } options.push(