From 1ff8ec51207866bd9dee6a76dc6437995fdff9fc Mon Sep 17 00:00:00 2001 From: Yuya Ochiai Date: Thu, 23 Feb 2017 00:37:44 +0900 Subject: [PATCH] Fix window.open() looks not working Intorduced by f8fadcb8446001bf9b303bf086b4ac01d7fd7e8d because {show:false} option was inherited from the main window. https://github.com/electron/electron/blob/v1.4.13/docs/api/window-open.md Close #450 --- src/browser/components/MattermostView.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/components/MattermostView.jsx b/src/browser/components/MattermostView.jsx index c23d274b..60231595 100644 --- a/src/browser/components/MattermostView.jsx +++ b/src/browser/components/MattermostView.jsx @@ -72,7 +72,7 @@ const MattermostView = React.createClass({ } if (currentURL.host === destURL.host) { // New window should disable nodeIntergration. - window.open(e.url, 'Mattermost', 'nodeIntegration=no'); + window.open(e.url, 'Mattermost', 'nodeIntegration=no,show=yes'); } else { // if the link is external, use default browser. shell.openExternal(e.url);