From 405403ca99fe784e972f5a9ed82d1a295aa46d77 Mon Sep 17 00:00:00 2001 From: Devin Binnie <52460000+devinbinnie@users.noreply.github.com> Date: Fri, 16 Feb 2024 12:27:30 -0500 Subject: [PATCH] [MM-56882] Fix a potential crash in diagnostics (#2960) --- src/main/diagnostics/steps/internal/utils.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/main/diagnostics/steps/internal/utils.ts b/src/main/diagnostics/steps/internal/utils.ts index ad2f8584..2a9e3d56 100644 --- a/src/main/diagnostics/steps/internal/utils.ts +++ b/src/main/diagnostics/steps/internal/utils.ts @@ -72,10 +72,14 @@ export async function isOnline(logger: ElectronLog = log, url = IS_ONLINE_ENDPOI resp.on('end', () => { logger.debug('resp.on.end', {data, url}); if (data.length) { - const respBody = JSON.parse(data); - if (respBody.status === 'OK') { - resolve(true); - return; + try { + const respBody = JSON.parse(data); + if (respBody.status === 'OK') { + resolve(true); + return; + } + } catch (e) { + logger.error('Cannot parse response') } } resolve(false);