Merge branch 'fix-win10-notifications-icon'

This commit is contained in:
Yuya Ochiai 2016-07-27 00:22:57 +09:00
commit 7e34358053
2 changed files with 12 additions and 3 deletions

View file

@ -4,8 +4,11 @@
### Improvements
#### Windows
- Use the application icon for desktop notifications in Windows 10.
#### Linux
- Added an option to make the taskbar icon flash on new messages
- Added an option to make the taskbar icon flash on new messages
### Bug Fixes

View file

@ -1,9 +1,15 @@
const OriginalNotification = Notification;
const appIconURL = `file:///${require('electron').remote.app.getAppPath()}/resources/appicon.png`;
function override(eventHandlers) {
Notification = function(title, options) {
// Notification Center shows app's icon, so there were two icons on the notification.
if (process.platform === 'darwin') {
if (process.platform === 'win32') {
// Replace with application icon.
options.icon = appIconURL;
}
else if (process.platform === 'darwin') {
// Notification Center shows app's icon, so there were two icons on the notification.
delete options.icon;
}
this.notification = new OriginalNotification(title, options);