From a1071277d6ad2da17c1979f166988a3e31a2ca46 Mon Sep 17 00:00:00 2001 From: Devin Binnie <52460000+devinbinnie@users.noreply.github.com> Date: Fri, 10 Nov 2023 09:02:34 -0500 Subject: [PATCH] [MM-55261] Allow embedded video links to go fullscreen after a permission check (#2905) --- src/main/permissionsManager.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/main/permissionsManager.ts b/src/main/permissionsManager.ts index 2d1b4967..9ed0ed5e 100644 --- a/src/main/permissionsManager.ts +++ b/src/main/permissionsManager.ts @@ -105,13 +105,17 @@ export class PermissionsManager extends JsonFileManager { return false; } + // Exception for embedded videos such as YouTube + // We still want to ask permission to do this though + const isExternalFullscreen = permission === 'fullscreen' && parsedURL.origin !== serverURL.origin; + // is the requesting url trusted? - if (!(isTrustedURL(parsedURL, serverURL) || (permission === 'media' && parsedURL.origin === serverURL.origin))) { + if (!(isTrustedURL(parsedURL, serverURL) || (permission === 'media' && parsedURL.origin === serverURL.origin) || isExternalFullscreen)) { return false; } // For certain permission types, we need to confirm with the user - if (authorizablePermissionTypes.includes(permission)) { + if (authorizablePermissionTypes.includes(permission) || isExternalFullscreen) { const currentPermission = this.json[parsedURL.origin]?.[permission]; // If previously allowed, just allow