aaron/mattermost-desktop
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

[MM-60232] Fix a crash in Linux when trying to create a thumbnail from an image (#3147)

Browse source 
* [MM-60232] Fix a crash in Linux when trying to create a thumbnail from an image

* Fix lint

* Cap at 1MB

* Fix crash again
This commit is contained in:
Devin Binnie 2024-09-19 15:00:30 -04:00 committed by GitHub
parent b03bb69a0d
commit b4eeabb366
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/main/downloadsManager.ts
View file

@ -635,7 +635,15 @@ export class DownloadsManager extends JsonFileManager<DownloadedItems> {
let thumbnailData; let thumbnailData;
if (state === 'completed' && item.getMimeType().toLowerCase().startsWith('image/')) { if (state === 'completed' && item.getMimeType().toLowerCase().startsWith('image/')) {
thumbnailData = (await nativeImage.createThumbnailFromPath(overridePath ?? item.getSavePath(), {height: 32, width: 32})).toDataURL(); // Linux doesn't support the thumbnail creation so we have to use the base function
if (process.platform === 'linux') {
// We also will cap this at 1MB so as to not inflate the memory usage of the downloads dropdown
if (item.getReceivedBytes() < 1000000) {
thumbnailData = (await nativeImage.createFromPath(overridePath ?? item.getSavePath())).toDataURL();
}
} else {
thumbnailData = (await nativeImage.createThumbnailFromPath(overridePath ?? item.getSavePath(), {height: 32, width: 32})).toDataURL();
}
} }
return { return {