Merge pull request #529 from yuya-oc/default-spellchecker-enabled

Enable spellchecker as default setting

Close #527

src/common/settings.js

@@ -24,7 +24,7 @@ function loadDefault(version, spellCheckerLocale) {
         flashWindow: 0 // 0 = flash never, 1 = only when idle (after 10 seconds), 2 = always
       },
       showUnreadBadge: true,
-      useSpellChecker: false,
+      useSpellChecker: true,
       spellCheckerLocale: spellCheckerLocale || 'en-US'
     };
   default:

src/main.js

@@ -96,7 +96,8 @@ try {
     settings.writeFileSync(configFile, config);
   }
 } catch (e) {
-  config = settings.loadDefault();
+  const spellCheckerLocale = SpellChecker.getSpellCheckerLocale(app.getLocale());
+  config = settings.loadDefault(null, spellCheckerLocale);
   console.log('Failed to read or upgrade config.json', e);
 }
 

test/specs/browser/settings_test.js

@@ -208,11 +208,12 @@ describe('browser/settings.html', function desc() {
           loadSettingsPage().
           isExisting('#inputSpellChecker').then((existing) => existing.should.equal(true)).
           scroll('#inputSpellChecker').
+          isSelected('#inputSpellChecker').then((selected) => selected.should.equal(true)).
           click('#inputSpellChecker').
           pause(700).
           then(() => {
             const config1 = JSON.parse(fs.readFileSync(env.configFilePath, 'utf-8'));
-            config1.useSpellChecker.should.equal(true);
+            config1.useSpellChecker.should.equal(false);
           });
       });
     });