Devin Binnie
9a518e8e76
[MM-40632] Updates to the Developer Documentation and README, remove unnecessary files and code ( #1922 )
...
* [MM-40632] Updates to the Developer Documentation and README, remove unnecessary files and code
* Update CONTRIBUTING.md
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
* Update CONTRIBUTING.md
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
* Update CONTRIBUTING.md
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
* Update README.md
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
* Update README.md
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
* Update TESTING.md
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
* Update TESTING.md
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
* Update TESTING.md
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
* Update TESTING.md
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
* Update TESTING.md
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
* Update CONTRIBUTING.md
Co-authored-by: Guillermo Vayá <guivaya@gmail.com>
* Update TESTING.md
Co-authored-by: Guillermo Vayá <guivaya@gmail.com>
* PR feedback
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
Co-authored-by: Guillermo Vayá <guivaya@gmail.com>
2021-12-17 15:00:35 -05:00
Devin Binnie
8474683ff1
[MM-40603] Add timeout for alt press to make sure it doesn't interfere with OS shortcuts ( #1932 )
...
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2021-12-17 10:53:22 -05:00
Devin Binnie
c4e63fb3f9
[MM-40574] Fix for race condition where new server modal didn't show initially on Linux, resizing issues ( #1865 )
...
* FIx for linux modal sizing
* Fix race condition, merge'd
2021-12-17 09:10:08 -05:00
Devin Binnie
9b1ee66c8c
[MM-32946][MM-40602] Ensure URL is valid before showing tooltip link, allow parsed URLs that aren't valid to open in browser ( #1925 )
...
* [MM-40602] Ensure URL is valid before showing tooltip link
* Rework to allow invalid URLs to display
* [MM-32946] Allow parsable URLs and open invalid URIs in browser
2021-12-16 10:06:11 -05:00
Devin Binnie
5ef1f56d63
Disable flaky test ( #1928 )
2021-12-15 16:17:44 -05:00
Profesor08
a410222e14
add hide on start option ( #1919 )
...
* add hide on start option (#1918 )
* text update
* clean up
* removed `hideOnStart` from ConfigV1 & ConfigV2
* tests update
2021-12-13 15:19:59 +01:00
ChristophKaser
fca6a75ee4
[GH-1635] don't validate custom protocol URLs ( #1889 )
...
* don't validate custom protocol URLs
* added unit tests for invalid URLs with custom protocols
2021-12-10 11:30:10 +01:00
Devin Binnie
39fbdf45c5
[MM-40406] Add more singletons, refactor main.ts into pieces, add tests and some cleanup + tests for additional coverage ( #1890 )
...
* Refactor main.ts dependencies into singleton pattern
* Split main.ts into testable pieces, some other refactoring for singleton pattern
* Unit tests for main/app/app
* Unit tests for main/app/config
* Unit tests for main/app/initialize
* Unit tests for main/app/intercom
* Unit tests for main/app/utils
* Add some more tests to get to 70% coverage
* Fix for linux
* Fix for alternate data dir paths
* Fix E2E test
2021-12-09 15:11:55 -05:00
Devin Binnie
850eadceb9
[MM-40192] Don't send message until server is finished reloading ( #1886 )
...
* [MM-40192] Don't send message until server is finished reloading
* Error check
2021-12-09 12:44:44 -05:00
Devin Binnie
4a98dce51e
[MM-40330] Unit tests for main/windows ( #1885 )
...
* [MM-40330] Unit tests for main/windows
* Merge'd
2021-12-06 11:08:39 -05:00
Devin Binnie
72f7cb4f08
[MM-40329] Unit tests for main/views ( #1883 )
...
* WIP
* [MM-40329] Unit tests for main/views
* Lint/type fix
* Merge'd
2021-12-06 10:13:26 -05:00
Devin Binnie
73056d2649
Code cleanup, update eslint from webapp, add ts-prune ( #1884 )
2021-12-03 16:01:49 -05:00
Claudio Costa
875a0f8bfd
Expose native API call to get desktop screen sources ( #1881 )
...
* Expose native API call to get screen sources
* Move eslint line to the bottom
2021-11-29 10:18:49 +01:00
Devin Binnie
5056ec7ace
[MM-40277][MM-40279][MM-40301][MM-40307][MM-40310][MM-40313] Unit tests and refactors for main module ( #1876 )
...
* Refactor autoLauncher and remove unnecessary file
* [MM-40277] Unit tests for main/badge
* [MM-40279] Unit tests for main/certificateStore
* [MM-40301] Unit tests for main/contextMenu, also remove workaround
* [MM-40307] Unit tests for main/CriticalErrorHandler
* [MM-40310] Unit tests for main/utils
* [MM-40313] Unit tests for main/Validator
* Lint fix
* Added globals
* More things that should probably already be merged
* PR feedback
2021-11-26 11:14:26 -05:00
Devin Binnie
fc06dc99a2
[MM-40328] Unit tests for main/server ( #1880 )
2021-11-26 10:21:38 -05:00
Devin Binnie
d1eaed8b32
[MM-40266] Refactor and tests for main/allowProtocolDialog ( #1875 )
2021-11-26 09:54:13 -05:00
Devin Binnie
d0e1936b2c
[MM-40146][MM-40147] Unit tests for authManager and certificateManager ( #1874 )
2021-11-26 09:35:28 -05:00
Devin Binnie
d358369ff9
[MM-40327] Unit tests for main/notifications ( #1879 )
2021-11-26 09:35:00 -05:00
Devin Binnie
b20e139971
[MM-40316] Unit tests for main/menus ( #1877 )
...
* Unit tests for main/menus/app
* Also this
* Unit tests for main/menus/tray
2021-11-25 10:41:12 -05:00
Devin Binnie
a4a275bd73
[MM-39491] Force Add Server modal to stay until server has been added ( #1869 )
...
* [MM-39491] Force Add Server modal to stay until server has been added
* Make the parameter optional
* Actually do the logic, add a test for the logic
* Add remove event listener
2021-11-25 09:47:20 -05:00
Devin Binnie
b4903d24c9
Remove unnecessary test case ( #1878 )
2021-11-24 09:18:53 -05:00
Devin Binnie
eab1f32a35
[MM-35441] Remove old cert, changes for building node modules ( #1863 )
...
* Testing new code cert
* Try again
* FASTA
* EVEN MOAR FADSTA
* TELL ME WHY
* AINT NOTHIN BUT A HEARTACHE
* Trying something
* Trying something else
* Remove unnecessary changes
* Update package-lock.json
* Remove cert
* Testing
* More testing
* Revert "Testing"
This reverts commit e8a471e2ff545123ac3c5d28adb5934b74fc8c48.
* Revert "More testing"
This reverts commit c4e31358e3ae6b14d38b04a20726b650cc7355d0.
2021-11-22 09:54:53 -05:00
Devin Binnie
3b4437e480
[MM-40025] Stop app from redirecting to tabs when not logged in ( #1870 )
2021-11-22 09:49:53 -05:00
Devin Binnie
4fa89a5fce
[MM-40144] Restructure tests, add test case numbers, some cleanup ( #1864 )
...
* [MM-40144] Restructure tests, add test case numbers, some cleanup
* Fix a test
2021-11-19 10:21:34 -05:00
Devin Binnie
113d87fe04
[MM-39888][MM-39960][MM-39961] Added tests for common/tabs, common/config, added coverage tool ( #1857 )
...
* [MM-39888] Unit tests for common/config
* [MM-39960][MM-39961] Added tests for common/tabs, added coverage tool
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2021-11-10 09:51:56 -05:00
Devin Binnie
38270fcfe8
[MM-39885] Migrate unit tests to Jest, fleshed out tests for common/util, a bunch of cleanup ( #1852 )
...
* [MM-39885] Migrate unit tests to Jest, fleshed out tests for common/util/url
* Typo fix
* Oops
* I found more tests!
* Fixed a bug
* Oops again
* Tests for common/utils/util
* A bunch of cleanup
* Oops
2021-11-08 10:04:47 -05:00
Devin Binnie
fbb3c9c705
[MM-39843] Show main window on second instance ( #1848 )
2021-11-08 09:24:19 -05:00
Devin Binnie
0bd5a54c76
[MM-39839] Changes for writing unit tests, some re-org ( #1849 )
...
* Move tests to individual folders
* Moved e2e tests to e2e folder, fixed lint issues
* Lint fix
2021-11-04 11:29:32 -04:00
Devin Binnie
ba974dbf75
[MM-39428] Check for EBUSY, add retry logic and logging for writing to config ( #1845 )
2021-11-03 09:26:56 -04:00
Devin Binnie
ff8a04245e
[MM-39737] E2E test checking for focused input in Add Server Modal ( #1846 )
2021-11-03 09:10:26 -04:00
Devin Binnie
3e36773e3a
[MM-39665] MM-T1285 Edit Server Modal ( #1841 )
...
* [MM-39665] MM-T1285 Edit Server Modal
* Lint fix
2021-10-29 12:21:47 -04:00
Devin Binnie
bb3269f2f6
[MM-39680] E2E Test for Deep Linking ( #1843 )
...
* [MM-39680] E2E Test for Deep Linking
* Only for Win32
2021-10-29 11:28:52 -04:00
Devin Binnie
c53e897bfd
[MM-38875] Migrate E2E testing to Playwright, re-enable tests ( #1800 )
...
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* WIP
* [MM-38875] Migrate E2E testing to Playwright, re-enable tests
* Add functionality to map view names to Playwright windows
* Added search box test
* Added robot.js for automating key presses
* Add test using key strokes to navigate menu
* Reload test and added webcontentsid to test helper
* Check Ctrl+Shift+R as well
* oops
* Reorganize
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2021-10-28 13:17:10 -04:00
Devin Binnie
bd0d9df7e3
Remove uses of restore_cache ( #1835 )
2021-10-22 10:56:23 -04:00
Devin Binnie
047db6e6e8
Changed version checking code for native window and correctly support frameless on Windows 8 ( #1829 )
2021-10-19 16:04:00 -04:00
Devin Binnie
cde76cc15f
Fixed issue with GPO navigation between tabs ( #1822 )
2021-10-19 09:05:49 -04:00
NeroBurner
f14f4062f6
CI: remove PR specific job enablement ( #1798 )
...
The following commit added the PR to the jobs to build for. This isn't needed anymore, so remove
9e440c6db9 (diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47)
Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>
2021-10-19 10:14:27 +02:00
Devin Binnie
ebba86bc08
Fixed issue with notification sounds not working correctly ( #1818 )
2021-10-18 18:22:58 -04:00
Devin Binnie
12052d4e0b
Fixed serverAPI throwing error on proxy server challenge, improved modals ( #1820 )
2021-10-18 12:46:32 -04:00
Eli Young
2194ca85ca
Use build/ as CircleCI workspace ( #1810 )
...
* Use build/ as CircleCI workspace
webpack compiles the application code to dist/ and electron-builder
treats it as a source of content to be packaged. As such, using this
path for CircleCI's workspace can cause unwanted scratch files to be
packaged into the app. By instead using build/, we solve the issue.
Moving the entitlements plist to the root of the repo is appropriate
because that's where all the other build config files currently live.
Fixes : #1809
* Update config.yml
Co-authored-by: Devin Binnie <devin.binnie@mattermost.com>
2021-10-14 17:19:44 -04:00
Devin Binnie
6ae15b0cea
[MM-39310] Add setTimeout to new server modal pop to make sure it renders correctly. ( #1811 )
2021-10-14 17:19:22 -04:00
Devin Binnie
cc4ddc3c18
[MM-39209] Check that Channels isn't redirecting to /
to prevent a refresh ( #1807 )
2021-10-14 09:25:21 -04:00
Devin Binnie
5e104ab335
[MM-39194] Removing call to focus() causing crash on macOS ( #1801 )
2021-10-08 11:38:28 -04:00
Devin Binnie
9e440c6db9
[MM-39047] Switch order of installers to avoid extra files being embedded ( #1790 )
...
* [MM-39047] Switch order of installers to avoid extra files being embedded
* CircleCi change
2021-10-06 17:05:13 -04:00
Devin Binnie
48cf6fd788
[MM-39160] Remove view from closedViews when it's automatically opened ( #1791 )
2021-10-06 17:05:07 -04:00
Devin Binnie
3527679648
Fix URL view cutoff for long URLs ( #1793 )
2021-10-06 16:32:27 -04:00
Devin Binnie
d1e5505bd4
[MM-39139] Workaround for transparency issue for BrowserViews on Electron v14.1.0+ ( #1792 )
2021-10-06 16:26:01 -04:00
Devin Binnie
67ddac1830
Fix electron-builder path for Linux ( #1788 )
2021-10-06 11:42:55 -04:00
Devin Binnie
ca1457f023
[MM-38991] Remove mentions and unreads when unloading a view ( #1780 )
2021-10-05 10:18:27 -04:00
Devin Binnie
658aec559d
Fix GitHub release markdown for mac universal change ( #1775 )
...
* Fix GitHub release markdown for mac universal change
* Update scripts/generate_release_markdown.sh
Co-authored-by: Guillermo Vayá <guivaya@gmail.com>
Co-authored-by: Guillermo Vayá <guivaya@gmail.com>
2021-10-05 10:17:07 -04:00