Commit graph

2688 commits

Author SHA1 Message Date
Devin Binnie a33d98ff8a
[MM-42010] Remove CircleCI check for E2E tests (#2009)
* [MM-42010] Remove CircleCI check for E2E tests

* Add jest test reporting

* Remove MM docker setup code

* Try old method

* oops

* Forgot to remove MM docker check
2022-03-02 09:39:24 -05:00
Devin Binnie fc13f877f2
[MM-30713] Stop Linux and Windows app from minimizing/hiding without user warning (#1988)
* [MM-30713] Stop Linux app from minimizing/hiding without user warning

* Added same behaviour for Windows

* Update messages

* Change wording

* Fix for accidentally disabled setting
2022-03-01 12:35:27 -05:00
chris-nee 062ca92f31
[MM-T820][MM-T821] Toggle developer Tools in the Menu Bar (#1990)
* test: MM-T820 MMT821 helper functions to be used by tests

* test: MM-T820 keyboard shortcut opens dev tools for Application Wrapper

* test: MM-T820 open dev tools for Application Wrapper through menu, Menu Dropdown > View > Developer Tools for Application Wrapper

* test: MM-T821 open dev tools for Current Server through menu, Menu Dropdown > View > Developer Tools for Current Server

* test: MM-T820 MMT821 scope tests in separate describe block

* test: MM-T820 MMT821 add help functions used for basic interactions with dev tools console

* test: MM-T820 MMT821 add constant setting values used to configure interactions with dev tools console

* test: MM-T820 check if dev tools is pointing to index.html file by sending alert dialogue from dev tool and detecting the dialog event on page, when opening dev tool using keyboard shortcut

* test: MM-T820 check if dev tools is pointing to index.html file by sending alert dialogue from dev tool and detecting the dialog event on page, when opening dev tool using menu

* test: MM-T821 check if dev tools is pointing to current application server by sending alert dialogue from dev tool and detecting the dialog event on page, when opening dev tool using menu

* test: MM-T820 MMT821 increase timeout value of test suite as more time is needed for dev tools to be ready for interaction

* test: MM-T820 MMT821 remove extra whitespace when sending command to dev tools console

* test: MM-T820 MMT821 split check for dev tools open and where dev tools
is pointing to as 2 different parts

test: MM-T820 MMT821 fix lint errors
2022-02-24 09:51:46 -05:00
Goh Yin Hao 88fd18ef02
[MM-T2637] add e2e test for minimize/maximize app when double click header (#1983) 2022-02-23 09:09:37 -05:00
Devin Binnie d779e87937
Ensure pathname starts with / (#2000) 2022-02-08 15:20:53 -05:00
Suneet Srivastava 54a1aefe52
test:MM-T809/MM-T810/MM-T811 Cut/Copy/Paste in the Menu Bar (#1978) 2022-02-08 09:31:13 -05:00
Profesor08 1c71579bbe
#1960 fix unexpected top menu focus (#1963)
* #1960 fix unexpected top menu focus

* #1960 test update

* #1960 improved test

* #1960 optimized algrithm to handle only Alt key to improve performance and avoid side effects

* #1960 tests update

* #1960 fixed 3 dit menu focus on workspace change with Alt+1, Alt+2

* #313 fix linter issue

* #1960 fix linter issue

* tests update
2022-02-08 09:23:51 -05:00
Devin Binnie 301ba8deb2
[MM-41392] Clean path name on browser pushes for subpaths (#1993) 2022-02-04 12:21:05 -05:00
Devin Binnie 94cc15168c
[MM-41559] Dynamically size URL view to avoid overlapping bottom links (#1991) 2022-02-04 11:05:06 -05:00
Suneet Srivastava e4394caf97
test:MM-T817/MM-T818/MM-T819 Zooming in the Menu Bar (#1979)
* test:MM-T817/MM-T818/MM-T819 Zooming in the Menu Bar

* test:MM-T818/T819 Zoom in zoom out in the menu bar
2022-02-03 11:04:53 -05:00
Suneet Srivastava 2e8a2b1330
test:MM-T816 Toggle Full Screen in the Menu Bar (#1976) 2022-02-02 16:02:45 -05:00
Suneet Srivastava 6682425587
test:MM-T1308 Check that external links dont open in the app (#1982) 2022-02-02 16:02:17 -05:00
Suneet Srivastava f7e2743b7e
test:MM-T808 Redo in the Menu Bar (#1977) 2022-02-02 12:33:40 -05:00
Rohitesh Gupta 6807019431
test:MM-T824/MM-T825 Minimize/Close in the Menu Bar (#1975)
* Added E2E test for Desktop - Minimize and Close

* Fixed padding blank lines

* Fixed test

* Changed robot keyTap

* Slight rework and fixes for flakiness

* Try sleeping longer

* Added .skip

* Fix linting error caused by merge

Co-authored-by: Devin Binnie <devin.binnie@mattermost.com>
Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>
2022-01-31 17:34:06 -05:00
Ujjwal Sharma c49aadc563
[MM-40051] MM-T4385 select tab from menu (#1962)
* MM-T4385 select tab from menu

* revert package-lock

* lint errors

* package revert

* test name corrected

* robot js keytap introduced

* package.json rever
2022-01-31 15:04:27 -05:00
Suneet Srivastava aa9e177895
test:MM-T812 Select All in the Menu Bar (#1973) 2022-01-31 12:32:03 -05:00
Md_ZubairAhmed 6702f41143
test: MM-T806 Exit in the Menu Bar (#1980) 2022-01-31 21:09:49 +05:30
Md_ZubairAhmed 5f489e28a0
test : MM-T2465 Linux Dark Mode Toggle (#1981) 2022-01-31 20:29:08 +05:30
Suneet Srivastava 88220bc1fd
test:Preferences in the Menu Bar opens the Settings page (#1959) 2022-01-31 09:20:52 -05:00
Suneet Srivastava cb3415e3da
test: Undo in the menu bar (#1969)
* test: Undo in the menu bar

* Fixed test

Co-authored-by: Devin Binnie <devin.binnie@mattermost.com>
2022-01-28 15:01:06 -05:00
Suneet Srivastava d58df0062f
test:Signin to another server open using menu bar (#1972) 2022-01-28 09:47:39 -05:00
Suneet Srivastava ac628bf930
feat: Added test for back and forward in history menu (#1965) 2022-01-27 09:26:43 -05:00
Ossi Väänänen 966febf684
Add scorecards analysis (#1971)
Github Action for Scorecard
https://github.com/ossf/scorecard

The Scorecard provides a (somewhat opinionated) view on the security posture of the repository -- we (the product security team) would like to adopt this on our key repositories to identify possible security improvements
2022-01-27 09:18:03 -05:00
Suneet Srivastava 089833f678
test:MM-T125 Copy Link can be used from channel LHS (#1966) 2022-01-25 10:02:35 -05:00
Devin Binnie 6803310217
[MM-35666] Re-ordered the priority of badge sources to leave session expired to last (#1955)
* Fixing some annoying things/stuff I broke

* [MM-35666] Re-ordered the priority of badge sources to leave session expired to last

* Fix tests
2022-01-25 09:51:25 -05:00
Alejandro García Montoro c43dfe6002
MM-41042: Allow trusted plugin routes (#1956)
* Allow trusted plugin routes

The only allowed plugin route is, for now, the export endpoint for the
channel export plugin.

* Keep it simple
2022-01-20 15:19:48 -05:00
Mylon Suren e446b13b34
[MM-39799] E2E Test: MM-T4050 Long server name (#1951)
* [MM-39799] - Add E2E tests for long server name

* [MM-39799] - Update test and css for max-width of tab

* [MM-39799] - Update max-width test to 400px
2022-01-20 09:51:54 -05:00
Sven Hüster 432af50ab3
change zoom in shortcut to match expected behavior (#1957) 2022-01-20 09:16:56 -05:00
Guillermo Vayá ba3f9a9c97
add a reminder on how to proceed with releases (#1656)
Co-authored-by: = <=>
2022-01-19 11:10:13 -05:00
Suneet Srivastava 9170930ada
[MM-39738] E2E test for Open Settings modal using keyboard shortcuts (#1947) 2022-01-18 23:27:32 +05:30
Devin Binnie 4a05b7c8d5
[MM-39852] Setup docker image to run in CI for E2E (#1946)
* [MM-39852] Setup docker image to run in CI for E2E

* Setup remote docker

* Install docker

* Trying this

* And this

* how about this

* this

* Okay this

* dis one

* sdfsagsdags

* Now?

* aaaaaaa

* asdasdasd

* i am dumb

* blank

* Please work

* Lint fix

* Forgot to update a couple things

* OOPS

* Testing something since this one is still failing

* Trying robotjs instead

* test

* Remove stop docker

* Try without the admin user (since apparently turning off admin notices didn't work)

* Remove console statement

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2022-01-17 10:20:11 -05:00
Julien Tant 6e8455e80e
Make WEBSERVER_PORT configurable with env variable (#1950) 2022-01-14 14:39:17 -05:00
Devin Binnie 4bdd8b7a45
[MM-40822] Remove app.dock.show from restoreMain (#1945)
* [MM-40822] Remove app.dock.show from restoreMain

* Removed the test
2022-01-12 09:38:45 -05:00
Sven Hüster 4d49f1bd38
change "tab" to "server" due to ui changes (#1948) 2022-01-12 09:36:01 -05:00
Devin Binnie 8f96fe42c7
[MM-32371] Communicate history information to webapp for disable/enabling Back/Forward buttons (#1941)
* [MM-32371] Communicate history information to webapp for disable/enabling Back/Forward buttons

* Merge'd
2022-01-10 17:38:23 -05:00
Colton Shaw 8ad949eedb
Menu > Help > version copied to clipboard on click (#1944) 2022-01-07 14:04:15 -05:00
Devin Binnie a49d748c16
[MM-40009] Add servers dropdown shortcut to menu (#1926)
* [MM-40009] Add servers dropdown shortcut to menu

* Lint fix

* Fix the shortcut for macOS

* Fix character
2022-01-06 10:40:19 -05:00
Devin Binnie adf494e944
[MM-36058][MM-40572] Tray fixes (#1933)
* [MM-36058] Added config migration function, update default tray icon theme to system, allow Windows users to override icon theme

* [MM-40572] Restore minimize to tray option for Windows

* Lint fix

* Test fix

* Oops
2022-01-04 15:00:56 -05:00
Devin Binnie 3ecdd3d1c9
[MM-26018] Added disclaimer for window flashing on Linux (#1927)
* [MM-26018] Added disclaimer for window flashing on Linux

* Update src/renderer/components/SettingsPage.tsx

Co-authored-by: Eric Sethna <eric@mattermost.com>

Co-authored-by: Eric Sethna <eric@mattermost.com>
2021-12-23 16:50:19 -05:00
Devin Binnie bd470459c2
[MM-40573] Stop asterisk detection on versions newer than 5.28, force space for the others (#1931)
* [MM-40573] Stop asking detection on versions newer than 5.29, force space for the others

* PR feedback and test fixes
2021-12-23 16:49:53 -05:00
Devin Binnie c28b219362
[MM-40635] Fix notifications and badges broken during test changes (#1934) 2021-12-23 16:49:12 -05:00
Devin Binnie 9a518e8e76
[MM-40632] Updates to the Developer Documentation and README, remove unnecessary files and code (#1922)
* [MM-40632] Updates to the Developer Documentation and README, remove unnecessary files and code

* Update CONTRIBUTING.md

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>

* Update CONTRIBUTING.md

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>

* Update CONTRIBUTING.md

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>

* Update README.md

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>

* Update README.md

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>

* Update TESTING.md

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>

* Update TESTING.md

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>

* Update TESTING.md

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>

* Update TESTING.md

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>

* Update TESTING.md

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>

* Update CONTRIBUTING.md

Co-authored-by: Guillermo Vayá <guivaya@gmail.com>

* Update TESTING.md

Co-authored-by: Guillermo Vayá <guivaya@gmail.com>

* PR feedback

Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
Co-authored-by: Guillermo Vayá <guivaya@gmail.com>
2021-12-17 15:00:35 -05:00
Devin Binnie 8474683ff1
[MM-40603] Add timeout for alt press to make sure it doesn't interfere with OS shortcuts (#1932)
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2021-12-17 10:53:22 -05:00
Devin Binnie c4e63fb3f9
[MM-40574] Fix for race condition where new server modal didn't show initially on Linux, resizing issues (#1865)
* FIx for linux modal sizing

* Fix race condition, merge'd
2021-12-17 09:10:08 -05:00
Devin Binnie 9b1ee66c8c
[MM-32946][MM-40602] Ensure URL is valid before showing tooltip link, allow parsed URLs that aren't valid to open in browser (#1925)
* [MM-40602] Ensure URL is valid before showing tooltip link

* Rework to allow invalid URLs to display

* [MM-32946] Allow parsable URLs and open invalid URIs in browser
2021-12-16 10:06:11 -05:00
Devin Binnie 5ef1f56d63
Disable flaky test (#1928) 2021-12-15 16:17:44 -05:00
Profesor08 a410222e14
add hide on start option (#1919)
* add hide on start option (#1918)

* text update

* clean up

* removed `hideOnStart` from ConfigV1 & ConfigV2

* tests update
2021-12-13 15:19:59 +01:00
ChristophKaser fca6a75ee4
[GH-1635] don't validate custom protocol URLs (#1889)
* don't validate custom protocol URLs

* added unit tests for invalid URLs with custom protocols
2021-12-10 11:30:10 +01:00
Devin Binnie 39fbdf45c5
[MM-40406] Add more singletons, refactor main.ts into pieces, add tests and some cleanup + tests for additional coverage (#1890)
* Refactor main.ts dependencies into singleton pattern

* Split main.ts into testable pieces, some other refactoring for singleton pattern

* Unit tests for main/app/app

* Unit tests for main/app/config

* Unit tests for main/app/initialize

* Unit tests for main/app/intercom

* Unit tests for main/app/utils

* Add some more tests to get to 70% coverage

* Fix for linux

* Fix for alternate data dir paths

* Fix E2E test
2021-12-09 15:11:55 -05:00
Devin Binnie 850eadceb9
[MM-40192] Don't send message until server is finished reloading (#1886)
* [MM-40192] Don't send message until server is finished reloading

* Error check
2021-12-09 12:44:44 -05:00