932ddafdb0
* [MM-19054] Added new server tab look and feel, still missing proper hover states and session expired icon * [MM-19055] Added window controls and removed border for macOS * [MM-19055] Add dark mode for macOS * [MM-19054] Added session expired icon * Test windows titlebar * Fixed the menu issue and added non-macOS dark mode * Blank commit * Fixed a lint issue * Fixed more lint issues * Fixed more issues * New tray icons * [MM-19603] Drag and drop tabs * Fixed some assets and fixed build output to include missing assets * Fixed a couple small issues * Only show tabs for only 1 server on Mac * Fixed some more tests * Fixed another test * Revert "Fixed another test" This reverts commit 36040294a71a68663d06996d71eecc5ed23d7014. * Fixed another test * Trial and error! * A bunch of additional fixes * Fixed a lint issue * Fixed restore focus on add server tab causing bad UX * Trial and error on flaky test again * Fixed some bugs based on PR feedback. * blank commit to push tests * Revert "Test windows titlebar" This reverts commit 9cd46b71b1427b75942434ac49185870d2437b85. * Remove the rest of the old new titlebar and fixes * Added three-dot link * New menu * Rest of new windows menu and other fixes * Fixed lint errors * Added windows 10 style title bar buttons for non mac OS * Lint fixes and enabled the tab bar regardless of number of servers * Missed one * Fixed unicode characters * Commenting out test that should no longer be applicable * Removed Windows 10 style titlebar icons and used material design instead * Fixed a lint issue * Some small UX fixes * blank commit * Fixed an issue where dropping the first tab moves it too far over before snapping into place * Additional style fixes * Another small issue fix * Back to Windows 10 style * Lint fixes * Accessible three dot menu * Lint fixes * Shrinking tabs when window is too small * Gradient between tabs and title bar buttons when window is too small * Add drag to gradient * Replaced icons, drag and drop cursor sticking fix, slight tab change * Lint and some mac fixes * Light theme fix to three dot menu * Hack for tab sticking to cursor on macOS * Fixes for the find utility * Fix for Catalina dark mode * Revert "Fix for Catalina dark mode" This reverts commit 45da05dd0f17f46efd1c53fafb92e9c1fd9dd8d9. * Fixed a couple issues Dean found * More fixes * Three dot hover effect to circle * PR feedback * Test fixes * Test and config fixes * Disable dragging when there are GPO servers * [MM-20757] Fixed dark mode on debug when running macOS Catalina * Allow future config versions to use v2 config if launching this version of the app * Oops * New titlebar icons, blur for titlebar on inactive * Lint fix * Set unfocused opacity to 0.4 * Final FINAL icons * Fixed closing menu not returning focus to the app * Lint fix * Update src/browser/components/TabBar.jsx Co-Authored-By: Guillermo Vayá <guivaya@gmail.com> * Update src/main/Validator.js Co-Authored-By: Guillermo Vayá <guivaya@gmail.com> * Lint fixes * Moved react-smooth-dnd fork to MM org and fixed another merge issue Co-authored-by: mattermod <mattermod@users.noreply.github.com> Co-authored-by: Guillermo Vayá <guivaya@gmail.com>
126 lines
3.3 KiB
JavaScript
126 lines
3.3 KiB
JavaScript
// Copyright (c) 2015-2016 Yuya Ochiai
|
|
// Copyright (c) 2016-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
'use strict';
|
|
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
const http = require('http');
|
|
|
|
const env = require('../modules/environment');
|
|
|
|
describe.skip('security', function desc() {
|
|
this.timeout(30000);
|
|
|
|
const serverPort = 8181;
|
|
const testURL = `http://localhost:${serverPort}`;
|
|
|
|
const config = {
|
|
version: 2,
|
|
teams: [{
|
|
name: 'example_1',
|
|
url: testURL,
|
|
order: 0,
|
|
}, {
|
|
name: 'example_2',
|
|
url: testURL,
|
|
order: 1,
|
|
}],
|
|
};
|
|
|
|
before(() => {
|
|
this.server = http.createServer((req, res) => {
|
|
res.writeHead(200, {
|
|
'Content-Type': 'text/html',
|
|
});
|
|
res.end(fs.readFileSync(path.resolve(env.sourceRootDir, 'test/modules/test.html'), 'utf-8'));
|
|
}).listen(serverPort, '127.0.0.1');
|
|
});
|
|
|
|
beforeEach(() => {
|
|
fs.writeFileSync(env.configFilePath, JSON.stringify(config));
|
|
this.app = env.getSpectronApp();
|
|
return this.app.start();
|
|
});
|
|
|
|
afterEach(() => {
|
|
if (this.app && this.app.isRunning()) {
|
|
return this.app.stop();
|
|
}
|
|
return true;
|
|
});
|
|
|
|
after((done) => {
|
|
this.server.close(done);
|
|
});
|
|
|
|
it('should NOT be able to call Node.js API in webview', () => {
|
|
env.addClientCommands(this.app.client);
|
|
|
|
// webview is handled as a window by chromedriver.
|
|
return this.app.client.
|
|
windowByIndex(1).isNodeEnabled().then((enabled) => {
|
|
enabled.should.be.false;
|
|
}).
|
|
windowByIndex(2).isNodeEnabled().then((enabled) => {
|
|
enabled.should.be.false;
|
|
}).
|
|
windowByIndex(0).
|
|
getAttribute('webview', 'nodeintegration').then((nodeintegration) => {
|
|
// nodeintegration is an array of string
|
|
nodeintegration.forEach((n) => {
|
|
n.should.equal('false');
|
|
});
|
|
});
|
|
});
|
|
|
|
it('should NOT be able to call Node.js API in a new window', () => {
|
|
env.addClientCommands(this.app.client);
|
|
const client = this.app.client;
|
|
return this.app.client.
|
|
windowByIndex(1). // in the first webview
|
|
execute(() => {
|
|
open_window();
|
|
}).
|
|
waitUntil(() => {
|
|
return client.windowHandles().then((handles) => {
|
|
return handles.value.length === 4;
|
|
});
|
|
}, 5000, 'expected a new window').
|
|
windowByIndex(3).isNodeEnabled().then((enabled) => {
|
|
enabled.should.be.false;
|
|
});
|
|
});
|
|
|
|
it('should NOT be able to call eval() in any window', () => {
|
|
env.addClientCommands(this.app.client);
|
|
const tryEval = (index) => {
|
|
return this.app.client.
|
|
windowByIndex(index).
|
|
execute(() => {
|
|
return eval('1 + 1');
|
|
}).then((result) => {
|
|
throw new Error(`Promise was unexpectedly fulfilled (result: ${result})`);
|
|
}, (error) => {
|
|
(error !== null).should.be.true;
|
|
});
|
|
};
|
|
const tryEvalInSettingsPage = () => {
|
|
return this.app.client.
|
|
windowByIndex(0).
|
|
loadSettingsPage().
|
|
execute(() => {
|
|
return eval('1 + 1');
|
|
}).then((result) => {
|
|
throw new Error(`Promise was unexpectedly fulfilled (result: ${result})`);
|
|
}, (error) => {
|
|
(error !== null).should.be.true;
|
|
});
|
|
};
|
|
return Promise.all([
|
|
tryEval(0),
|
|
tryEvalInSettingsPage(),
|
|
]);
|
|
});
|
|
});
|