mattermost-desktop/test/specs/browser/settings_test.js
Devin Binnie e76e0dc0a1
[MM-23067] Browser View (#1514)
* Browser-view: initial architectural changes + webpack (#1358)

* reorder code to support webpack

* start backend changes

* remove simple-spellchecker

* wip

* first browserview run

* settings window routing

* wip

* back to webpack

* working build

* back to using electron-builder

* fix linting

* linting errors missed

* back to just 1 config

* missing changes

* refactor and have the settings in its own page

* reminder to restore disabling window.eval

* remove old webpack generated files

* add assets files

* more remove files and fix localurls

* CR changes

* Browserview settings window (#1362)

* reorder code to support webpack

* start backend changes

* remove simple-spellchecker

* wip

* first browserview run

* settings window routing

* wip

* back to webpack

* working build

* back to using electron-builder

* fix linting

* linting errors missed

* back to just 1 config

* missing changes

* refactor and have the settings in its own page

* reminder to restore disabling window.eval

* wip

* wip

* remove old webpack generated files

* add assets files

* more remove files and fix localurls

* wip settings, needs fixing saving prefs

* remove linting errors

* remove settings as a modal

* fix linting

* remove view from window on destroy

* restore visibility if reloaded

* debug log

* look for closed windows, remove managers from settings as it is a full window

* restore view on configuration save

* linting and debug

* remove debug message

* [BrowserView] renderer (#1378)

* reorder code to support webpack

* start backend changes

* remove simple-spellchecker

* wip

* first browserview run

* settings window routing

* wip

* back to webpack

* working build

* back to using electron-builder

* fix linting

* linting errors missed

* back to just 1 config

* missing changes

* refactor and have the settings in its own page

* reminder to restore disabling window.eval

* wip

* wip

* remove old webpack generated files

* add assets files

* more remove files and fix localurls

* wip settings, needs fixing saving prefs

* remove linting errors

* remove settings as a modal

* fix linting

* remove view from window on destroy

* restore visibility if reloaded

* debug log

* look for closed windows, remove managers from settings as it is a full window

* restore view on configuration save

* linting and debug

* remove debug message

* make eslint be aware of webpack aliases

* some extra disable lines

* move badge management to main

* remove unneded import

* fixing errors

* wip

* back to having tabs

* switch tab working

* wip

* wip

* wip

* fix quitting error

* back to a working config

* configure retries

* add darkmode

* wip

* add error/loading screens

* fix settings while removing remote usage

* wip

* fix lint, get preload to load

* remove unused import

* remove log statements

* Bv menus (#1387)

* reorder code to support webpack

* start backend changes

* remove simple-spellchecker

* wip

* first browserview run

* settings window routing

* wip

* back to webpack

* working build

* back to using electron-builder

* fix linting

* linting errors missed

* back to just 1 config

* missing changes

* refactor and have the settings in its own page

* reminder to restore disabling window.eval

* wip

* wip

* remove old webpack generated files

* add assets files

* more remove files and fix localurls

* wip settings, needs fixing saving prefs

* remove linting errors

* remove settings as a modal

* fix linting

* remove view from window on destroy

* restore visibility if reloaded

* debug log

* look for closed windows, remove managers from settings as it is a full window

* restore view on configuration save

* linting and debug

* remove debug message

* make eslint be aware of webpack aliases

* some extra disable lines

* move badge management to main

* remove unneded import

* fixing errors

* wip

* back to having tabs

* switch tab working

* wip

* wip

* wip

* fix quitting error

* back to a working config

* configure retries

* add darkmode

* wip

* add error/loading screens

* fix settings while removing remote usage

* wip

* fix lint, get preload to load

* remove unused import

* wip

* menus initially working as they should

* update deps, show context menu

* wip

* wip

* wip

* fix forward/back menu

* fix server menu

* allow navigating to external urls in the browser

* add defaults to menu

* fix logic

* set default options

* remove logs

* wip

* package.json

* fix merge results

* fix package-lock

* remove debug statements

* address CR requests

* [MM-22691][Browserview] fix tray icon (#1403)

* reorder code to support webpack

* start backend changes

* remove simple-spellchecker

* wip

* first browserview run

* settings window routing

* wip

* back to webpack

* working build

* back to using electron-builder

* fix linting

* linting errors missed

* back to just 1 config

* missing changes

* refactor and have the settings in its own page

* reminder to restore disabling window.eval

* wip

* wip

* remove old webpack generated files

* add assets files

* more remove files and fix localurls

* wip settings, needs fixing saving prefs

* remove linting errors

* remove settings as a modal

* fix linting

* remove view from window on destroy

* restore visibility if reloaded

* debug log

* look for closed windows, remove managers from settings as it is a full window

* restore view on configuration save

* linting and debug

* remove debug message

* make eslint be aware of webpack aliases

* some extra disable lines

* move badge management to main

* remove unneded import

* fixing errors

* wip

* back to having tabs

* switch tab working

* wip

* wip

* wip

* fix quitting error

* back to a working config

* configure retries

* add darkmode

* wip

* add error/loading screens

* fix settings while removing remote usage

* wip

* fix lint, get preload to load

* remove unused import

* wip

* menus initially working as they should

* update deps, show context menu

* wip

* wip

* wip

* fix forward/back menu

* fix server menu

* allow navigating to external urls in the browser

* add defaults to menu

* fix logic

* set default options

* remove logs

* wip

* fix webpack adding images to /dist so tray can render them

* wait for config, fix menutray calls

* remove .gitattributes from being tracked

* remove unused reject

* remove logs

* Update webpack.config.renderer.js

Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>

Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>

* Browserview URLHover (#1393)

* reorder code to support webpack

* start backend changes

* remove simple-spellchecker

* wip

* first browserview run

* settings window routing

* wip

* back to webpack

* working build

* back to using electron-builder

* fix linting

* linting errors missed

* back to just 1 config

* missing changes

* refactor and have the settings in its own page

* reminder to restore disabling window.eval

* wip

* wip

* remove old webpack generated files

* add assets files

* more remove files and fix localurls

* wip settings, needs fixing saving prefs

* remove linting errors

* remove settings as a modal

* fix linting

* remove view from window on destroy

* restore visibility if reloaded

* debug log

* look for closed windows, remove managers from settings as it is a full window

* restore view on configuration save

* linting and debug

* remove debug message

* make eslint be aware of webpack aliases

* some extra disable lines

* move badge management to main

* remove unneded import

* fixing errors

* wip

* back to having tabs

* switch tab working

* wip

* wip

* wip

* fix quitting error

* back to a working config

* configure retries

* add darkmode

* wip

* add error/loading screens

* fix settings while removing remote usage

* wip

* fix lint, get preload to load

* remove unused import

* wip

* menus initially working as they should

* update deps, show context menu

* wip

* wip

* wip

* fix forward/back menu

* fix server menu

* allow navigating to external urls in the browser

* add defaults to menu

* fix logic

* set default options

* remove logs

* wip

* wip

* wip urlview

* wip

* urlview when hovering on a link

* change how to detect when the mouse hovers

* [BrowserView] remove remote usage, fix menus and window buttons in Win (#1418)

* reorder code to support webpack

* start backend changes

* remove simple-spellchecker

* wip

* first browserview run

* settings window routing

* wip

* back to webpack

* working build

* back to using electron-builder

* fix linting

* linting errors missed

* back to just 1 config

* missing changes

* refactor and have the settings in its own page

* reminder to restore disabling window.eval

* wip

* wip

* remove old webpack generated files

* add assets files

* more remove files and fix localurls

* wip settings, needs fixing saving prefs

* remove linting errors

* remove settings as a modal

* fix linting

* remove view from window on destroy

* restore visibility if reloaded

* debug log

* look for closed windows, remove managers from settings as it is a full window

* restore view on configuration save

* linting and debug

* remove debug message

* make eslint be aware of webpack aliases

* some extra disable lines

* move badge management to main

* remove unneded import

* fixing errors

* wip

* back to having tabs

* switch tab working

* wip

* wip

* wip

* fix quitting error

* back to a working config

* configure retries

* add darkmode

* wip

* add error/loading screens

* fix settings while removing remote usage

* wip

* fix lint, get preload to load

* remove unused import

* wip

* menus initially working as they should

* update deps, show context menu

* wip

* wip

* wip

* fix forward/back menu

* fix server menu

* allow navigating to external urls in the browser

* add defaults to menu

* fix logic

* set default options

* remove logs

* wip

* fix webpack adding images to /dist so tray can render them

* wait for config, fix menutray calls

* remove .gitattributes from being tracked

* remove unused reject

* remove logs

* Update webpack.config.renderer.js

Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>

* fix three dot menu

* remove most remote usage, fix window buttons in Windows

Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>

* fix different errors when loading config (#1420)

* [BrowserView] Native modules & registry access (#1417)

* reorder code to support webpack

* start backend changes

* remove simple-spellchecker

* wip

* first browserview run

* settings window routing

* wip

* back to webpack

* working build

* back to using electron-builder

* fix linting

* linting errors missed

* back to just 1 config

* missing changes

* refactor and have the settings in its own page

* reminder to restore disabling window.eval

* wip

* wip

* remove old webpack generated files

* add assets files

* more remove files and fix localurls

* wip settings, needs fixing saving prefs

* remove linting errors

* remove settings as a modal

* fix linting

* remove view from window on destroy

* restore visibility if reloaded

* debug log

* look for closed windows, remove managers from settings as it is a full window

* restore view on configuration save

* linting and debug

* remove debug message

* make eslint be aware of webpack aliases

* some extra disable lines

* move badge management to main

* remove unneded import

* fixing errors

* wip

* back to having tabs

* switch tab working

* wip

* wip

* wip

* fix quitting error

* back to a working config

* configure retries

* add darkmode

* wip

* add error/loading screens

* fix settings while removing remote usage

* wip

* fix lint, get preload to load

* remove unused import

* wip

* menus initially working as they should

* update deps, show context menu

* wip

* wip

* wip

* fix forward/back menu

* fix server menu

* allow navigating to external urls in the browser

* add defaults to menu

* fix logic

* set default options

* remove logs

* wip

* fix webpack adding images to /dist so tray can render them

* wait for config, fix menutray calls

* remove .gitattributes from being tracked

* restart-working native modules

* setup env variables for installing native modules

* [browserview] Electron notifications (#1411)

* reorder code to support webpack

* start backend changes

* remove simple-spellchecker

* wip

* first browserview run

* settings window routing

* wip

* back to webpack

* working build

* back to using electron-builder

* fix linting

* linting errors missed

* back to just 1 config

* missing changes

* refactor and have the settings in its own page

* reminder to restore disabling window.eval

* wip

* wip

* remove old webpack generated files

* add assets files

* more remove files and fix localurls

* wip settings, needs fixing saving prefs

* remove linting errors

* remove settings as a modal

* fix linting

* remove view from window on destroy

* restore visibility if reloaded

* debug log

* look for closed windows, remove managers from settings as it is a full window

* restore view on configuration save

* linting and debug

* remove debug message

* make eslint be aware of webpack aliases

* some extra disable lines

* move badge management to main

* remove unneded import

* fixing errors

* wip

* back to having tabs

* switch tab working

* wip

* wip

* wip

* fix quitting error

* back to a working config

* configure retries

* add darkmode

* wip

* add error/loading screens

* fix settings while removing remote usage

* wip

* fix lint, get preload to load

* remove unused import

* wip

* menus initially working as they should

* update deps, show context menu

* wip

* wip

* wip

* fix forward/back menu

* fix server menu

* allow navigating to external urls in the browser

* add defaults to menu

* fix logic

* set default options

* remove logs

* wip

* wip

* move viewmanager into windowmanager

* working notifications

* remove logs, switch tab on notification click

* download notifications

* fix tray

* fix menu switch server

* fix error

* [MM-23078] TabBar fixes for BrowserView (#1423)

* [MM-23078] TabBar fixes for BrowserView

* Removing unnecessary logging

* [Browserview] 4.6 and 4.7 PRs (#1424)

* [MM-28620] allow navigating links to admin_console #1374

* [MM-25789] - Update default settings for new installations #1376

* [MM-27332] show window at autolaunch #1379

* Update NOTICE.txt (#1385)

* Update NOTICE.txt

* Update NOTICE.txt

* Update NOTICE.txt

* convert to markdown

* md linting

* Update NOTICE.md

* Revert "Update NOTICE.md"

This reverts commit 9381fca895c0677bcad1cf1c1071ca88afd6f486.

* Revert "md linting"

This reverts commit e7a68f120109d47b9849cf816d4fef79483ad22f.

* Revert "convert to markdown"

This reverts commit 1e7ed8a67c9c98cd0d0f3ff6cdc70782effb143d.

* add missing licenses to joi and jq

* Remove devDependencies

Co-authored-by: Guillermo Vaya <guivaya@gmail.com>

* Notification sounds, also added tab name to notification title

* [MM-22013] - Allow users to specify default download locations #1383

* [MM-21835] Use URL instead of the url library #1384

* remove debug console.log statements

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* [MM-31266] fix access url when it's not a mm server (#1431)

* [MM-31224] fix reloading servers and other tab issues (#1434)

* [MM-31224] fix reloading servers and other tab issues

* reload if url changes

* Change the dev server port to 9001 to avoid conflict with mattermost-minio (#1437)

* remove dev_web_server (#1438)

* [MM-31225][MM-31217][MM-31219][Browserview] fix linux compilation + other fixes (#1433)

* fix linux errors

* remove registry, remove env_vars

* devtools in separate window, prevent config errors

* fix registry path

* move dist to root when packaging

* make devtools dettached to avoid browserview

* remove unneeded comment

* use reject in case of registry failure

* fix handling results

* fix application menu

* make linter happy

* fix missing key on apt-get (#1440) (#1442)

see https://github.com/electron-userland/electron-builder/issues/5485#issuecomment-749244332

* [MM-31221][BrowserView] first modal: adding a server while in a server view (#1400)

* reorder code to support webpack

* start backend changes

* remove simple-spellchecker

* wip

* first browserview run

* settings window routing

* wip

* back to webpack

* working build

* back to using electron-builder

* fix linting

* linting errors missed

* back to just 1 config

* missing changes

* refactor and have the settings in its own page

* reminder to restore disabling window.eval

* wip

* wip

* remove old webpack generated files

* add assets files

* more remove files and fix localurls

* wip settings, needs fixing saving prefs

* remove linting errors

* remove settings as a modal

* fix linting

* remove view from window on destroy

* restore visibility if reloaded

* debug log

* look for closed windows, remove managers from settings as it is a full window

* restore view on configuration save

* linting and debug

* remove debug message

* make eslint be aware of webpack aliases

* some extra disable lines

* move badge management to main

* remove unneded import

* fixing errors

* wip

* back to having tabs

* switch tab working

* wip

* wip

* wip

* fix quitting error

* back to a working config

* configure retries

* add darkmode

* wip

* add error/loading screens

* fix settings while removing remote usage

* wip

* fix lint, get preload to load

* remove unused import

* wip

* menus initially working as they should

* update deps, show context menu

* wip

* wip

* wip

* fix forward/back menu

* fix server menu

* allow navigating to external urls in the browser

* add defaults to menu

* fix logic

* set default options

* remove logs

* wip

* wip

* wip urlview

* wip

* urlview when hovering on a link

* wip

* wip

* first working modal

* fix config loading

* upgrade electron to 10.1.5

* esc exits modals

* first modal

* add env variables for settings and modals devtools

* adress CSS review comments

* Address review comments

* fix dist in prod

* fix preload path on build

* [MM-31987] Allow camera use for jitsi (#1443) (#1450)

* [MM-31987] allow camera use for jitsi

* update message for access

* [MM-31261] Use manual resizing of BrowserViews on resize, maximize and full-screen (#1449)

* [MM-31261] Use manual resizing of BrowserViews on resize, maximize and full-screen

* Update src/main/windows/windowManager.js

Co-authored-by: Guillermo Vayá <guivaya@gmail.com>

Co-authored-by: Guillermo Vayá <guivaya@gmail.com>

* add own branch for testing (#1448)

* add own branch for testing

* remove signing for windows

* add message to channel

* Bv pipeline elisabeth (#1452)

* Add parameter and remove schedule

* Add jq

* Fix adding jq

* Fix adding jq

* Fix adding jq

* fix quotes

* upload as JSON

* use previous, parse json

* fixes

* use json

Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>

* [MM-30144][MM-30145][MM-30146][MM-30147] Migrate auth and certificate modals to BrowserView (#1445)

* WIP

* WIP

* WIP

* WIP

* WIP

* [MM-30144][MM-30145] Migrate LoginModal and PermissionModal to BrowserView

* [MM-30146][MM-30147] Migrate certificate modals to BrowserView

* Fixed transparency on the bootstrap modals

* PR feedback

* Added better error reporting in case the modal promise fails

* [MM-31233] Reverse maximize logic typo (#1454)

* [browser view] MM-32277 bump version, exe, cache errrors (#1456)

* bump version

* enable msi and remove src/package*

* ensure variable exists

* remove cleanCache script

* default expansion for env variable

* add commit version, missing package-lock.json

* remove duplicated command

* [MM-31467] Move protocol handling over from original MattermostView into web contents handler (#1453)

* WIP

* WIP

* [MM-31467] Move protocol handling over from original MattermostView into web contents handler

* Remove log statement

* [MM-32392] prevent crash when checking a URL (#1457)

* [MM-31215][MM-31387] Fixes for bad tab navigation and dragging (#1461)

* [MM-31387] Send to renderer on clicking server from settings window

* Use different event name for sending switch server info to renderer

* Have the viewManager let the renderer know when the tab has changed

* Couple more fixes around tabs

* Simplify URL compare logic

* [MM-31650] Restore focus to active server on modal and settings window closure + other fixes (#1455)

* [MM-31650] Focus active server on settings window and modal closure

* Disable tabs when a modal is open

* Revert to using original NewTeamModal component

* fix resize (#1462)

* [MM-32424] fix server devtools being hidden by browserview (#1459)

* [MM-32424] fix server devtools being hidden by browserview

* reverse logic

* [MM-20227][MM-31388] move to roles and fix focus (#1463)

* [MM-31570] update mentions/unreads/session on jewel, tray and dock (#1460)

* [MM-32333] Open public links in the user's default browser (#1468)

* [MM-32333] Open public links in the user's default browser

* Removed commented code

* [MM-31232] fix urlview present with no content (#1467)

* [MM-31343] Migrate Finder to BrowserView (#1466)

* WIP

* WIP

* WIP

* [MM-31343] Migrate Finder to BrowserView

* PR feedback

* Removing reference to this in non-class file

* use electron to handle spellchecking (#1469)

* [MM-32382] Use resize event instead of will-resize for monitoring size of BV (#1470)

* [MM-32570] Use OpenSans as the font for the URL preview modal (#1471)

* [MM-32570] Use OpenSans as the font for the URL preview modal

* Don't use bootstrap

* Fix draw badge (#1477)

* use canvas from window

* fix errors

* fix errors

* safer code injection

* [MM-31554] Add listener for config synchronization on the settings window (#1473)

* [MM-31554] Add listener for config synchronization on the settings window

* Synchronize the config if updated from outside the settings window

* [MM-28541] restore deeplinking (#1475)

* handle deeplinking

* fix app handling deeplinking

* remove outdated comment

* address review comments

* MM-32765_prevent crash on checking unread state (#1479)

* MM-31383 make no the default when asking to add a protocol (#1481)

* [MM-31340] Resize browser view and show back button when on non-team URL (#1472)

* WIP

* [MM-31340] Resize browser view and show back button when on non-team URL

* Fixed issue where switching tabs and resizing hides the back button

* Add error checking around going back in history

* [MM-31399] Use webapp ESLint config in desktop app and resolve inconsistencies (#1482)

* Import webapp eslint and update packages

* FIrst pass with new ruleset

* Allow setState

* Fix rule for tests

* Comment out skippeed tests, removed some TODOs and fixed some warnings

* Remove errors from MainPage

* Use indenting profile from webapp

* Update editorconfig for new indenting

* Fix indenting for class properties

* Only disable no-console for renderer process and scripts

* Remove rule overrides and changes

* Fix merge issues

* PR feedback and fixed a bad merge

* [MM-25122] Use modded version of winreg that supports UTF-8 (#1488)

* fix appicon path resolution (#1484)

* [MM-33141] Fixed use of bad context in TeamList (#1487)

* [MM-33141] Fixed use of bad context in TeamList

* Refactor to pull the functions out

* Remove unnecessary props

* [MM-25355] Throttle notifications for Windows by channel id (#1486)

* [MM-25355] Throttle notifications for Windows

* Use teamId as well to key the notifications

* Merge'd

* Use Map instead of Set

* [MM-33050] move webcontent events out of main (#1489)

* wip

* wip

* fix webcontent events, move views to its own folder

* [MM-33238] Check for admin URL when toggling back bar (#1495)

* [MM-31342] fix "save image as" context menu crash (#1490)

* [MM-33231] update jewel on new mentions/when read (#1493)

* [MM-33231] update state properly for a purecomponent

* remove unneeded comment

* [MM-33032] Use `hidden` titleBarStyle value to fix macOS Catalina click issue (#1496)

* [MM-32809] Remove Toggle Dark Mode menu item for Windows, enable toggling on Linux (#1494)

* [MM-32809] Remove Toggle Dark Mode menu item for Windows

* Just check for !win32 and !darwin

* Enable correct dark mode functionality on non-macOS/non-Windows machines

* [MM-33334] Restore keyboard shortcuts for menu items moved to roles (#1499)

* [MM-33434] Upgrade to Electron v11, some other dependency upgrades (#1501)

* [MM-33434] Upgrade to Electron v11, some other dependency upgrades

* Missed a version change

* context menu fix

* Forgot to remove a log statement

* Added resized for redundancy and upgraded to spectron 13

* Don't need resized

* [MM-33542] Trigger finder cleanup on pressing close or Escape (#1502)

* [MM-33542] Clear the Finder selection when closing the finder

* Remove listener on close as well

* Run close() on escape as well

* [MM-33607] Remove old badge code, update unreads code (#1503)

* [MM-33607] Remove old badge code, update unreads code

* Fix 2 random lint errors

* [MM-33247] Have the app handle links to other teams as a deep link (#1498)

* [MM-33373] Trigger the smaller font for 99+ mentions (#1507)

* [MM-32805] Merge master, migrate LoadingScreen to BrowserView (#1504)

* [MM-467] Notification sounds (#1351)

* Custom sounds

* Trying new version

* Trying new version

* Some fixes

* Rollback version change

* Allow native sound

* Increase version

* Playing custom sounds :)

* Fix var name

* Fix

* Update src/browser/js/notification.js

Co-authored-by: Guillermo Vayá <guivaya@gmail.com>

* Update src/browser/js/notification.js

Co-authored-by: Guillermo Vayá <guivaya@gmail.com>

* Update src/browser/js/notification.js

Co-authored-by: Guillermo Vayá <guivaya@gmail.com>

* Several suggestions

* Update src/browser/js/notification.js

Co-authored-by: Guillermo Vayá <guivaya@gmail.com>

* Restore of version

Co-authored-by: Guillermo Vayá <guivaya@gmail.com>

* Clean caches on depcheck failure (#1369)

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* [MM-28595] Open team links within the app (#1373)

* [MM-25789] - Update default settings for new installations (#1376)

* [MM-25789] - Update default settings for new installations

* Update src/main.js

Co-authored-by: Guillermo Vayá <guillermo.vaya@mattermost.com>

* Update src/main.js

Co-authored-by: Guillermo Vayá <guillermo.vaya@mattermost.com>

* Fix linter

Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MacBook-Pro-2.local>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Guillermo Vayá <guillermo.vaya@mattermost.com>

* add Russian language in the list available for spellcheck (#1375)

* [MM-28620] allow navigating links to admin_console (#1374)

* [MM-28620] allow navigating links to admin_console

* Fix when there is not a server associated

* [MM-27332] show window at autolaunch (#1379)

* Bump to version 4.7.0-develop

* Update NOTICE.txt (#1385)

* Update NOTICE.txt

* Update NOTICE.txt

* Update NOTICE.txt

* convert to markdown

* md linting

* Update NOTICE.md

* Revert "Update NOTICE.md"

This reverts commit 9381fca895c0677bcad1cf1c1071ca88afd6f486.

* Revert "md linting"

This reverts commit e7a68f120109d47b9849cf816d4fef79483ad22f.

* Revert "convert to markdown"

This reverts commit 1e7ed8a67c9c98cd0d0f3ff6cdc70782effb143d.

* add missing licenses to joi and jq

* Remove devDependencies

Co-authored-by: Guillermo Vaya <guivaya@gmail.com>

* [MM-9922] Hide tooltip for internal links (channels, timestamps, etc.) (#1386)

* Hide tooltip for internal links (channels, timestamps, etc.)

* Only hide tooltip for internal links on the *current* team

* feat(spellcheck): add Ukrainian language for spellcheck (#1382)

* [MM-29677] fix download complete notification not appearing (#1388)

* fix soundname not existing (#1390)

* [MM-29921] fix custom sound not playing when receiving a notification (#1396)

* [MM-29921] fix sound notification

* remove logs

* Update release-process.md (#1394)

* [MM-22013] - Allow users to specify default download locations (#1383)

* [MM-22013] - Allow users to specify default download locations

* PR comments

* Add proper config prop

* Update src/browser/components/SettingsPage.jsx

Co-authored-by: Guillermo Vayá <guillermo.vaya@mattermost.com>

* Remove string ref

* Fix styling

* Update styling

* Disable input

* Add variable for windows

* Prevent dialog from opening twice

Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MBP-2.fritz.box>
Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MacBook-Pro-2.local>
Co-authored-by: Guillermo Vayá <guillermo.vaya@mattermost.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* [MM-21835] Use URL instead of the url library (#1384)

Additionally, migrate all of the URL related helper functions
from `src/utils/utils.js` to the new `src/utils/url.js` file
and migrate tests.

Issue MM-21835
Fixes #1206

* Merge Powershell files together and remove AppVeyor related code

* Ensure nodejs deps are met before running script argument directly

* [MM-22810] Update loading screen with new design & animation (#1409)

* Update loading screen with new design & animation

* add prop back in

* adjust z-index for tests

* tweaks to pass tests

* address offline feedback

- shrink initial logo size
- introduce a slight delay before fading loading spinner out
- fix horizontal scrollbar showing on load screen

* add missing css variable

* no need to remove loading icon

* Apply suggestions from code review

Co-authored-by: Guillermo Vayá <guillermo.vaya@mattermost.com>

* Move LoadingScreen.jsx to file-only component

* Rename prop for better clarity

* Default prop to none and check when needed

* Update import paths

* Add ESDocs and remove unecessary conditional

* Forgot to remove the eslint override

Co-authored-by: Guillermo Vayá <guillermo.vaya@mattermost.com>

* [MM-22960] - Keep desktop app pinned to taskb bar when the app upgrades (#1397)

Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MacBook-Pro-2.local>

* Bump highlight.js from 9.18.1 to 9.18.5 (#1421)

Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 9.18.1 to 9.18.5.
- [Release notes](https://github.com/highlightjs/highlight.js/releases)
- [Changelog](https://github.com/highlightjs/highlight.js/blob/9.18.5/CHANGES.md)
- [Commits](https://github.com/highlightjs/highlight.js/compare/9.18.1...9.18.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ini from 1.3.5 to 1.3.7 (#1427)

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.7)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix missing key on apt-get (#1440)

see https://github.com/electron-userland/electron-builder/issues/5485#issuecomment-749244332

* [MM-31987] Allow camera use for jitsi (#1443)

* [MM-31987] allow camera use for jitsi

* update message for access

* Created codeql analysis (#1441)

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* [MM-31626] bypass gitlab browser-check for oauth login (#1439)

* MM-31626 make User Agent configurable by user

* add info

* remove chrome from UA for gitlab.com

* remove previous solution

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* Add Swedish sv-SE (already in simple-spellchecker) (#1483)

* Add Swedish sv-SE (already in simple-spellchecker)

* Remove spaces in empty lines

* Add some sv-SE test for spellchecker

Co-authored-by: Peter Johansson <peter.johansson@havochvatten.se>

* Add loading screen, fix reload

* WIP

* Migrate LoadingScreen to BrowserView

* Lint fixes

* Removed gitlab fix code, also returning null is bad apparently

* Fix reload logic

Co-authored-by: Rodrigo Villablanca <villa061004@gmail.com>
Co-authored-by: Guillermo Vayá <guivaya@gmail.com>
Co-authored-by: Juho Nurminen <juho.nurminen@mattermost.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Guillermo Vayá <guillermo.vaya@mattermost.com>
Co-authored-by: Nev Angelova <nevy.angelova@gmail.com>
Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MacBook-Pro-2.local>
Co-authored-by: Eugeny Fomin <github.com@jeka.ru>
Co-authored-by: Amy Blais <amy_blais@hotmail.com>
Co-authored-by: Nathan Bolender <nathan@nathanbolender.com>
Co-authored-by: Dmitriy Danilov <daniloff200@gmail.com>
Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MBP-2.fritz.box>
Co-authored-by: FalseHonesty <skipboman0@gmail.com>
Co-authored-by: William Gathoye <william@gathoye.be>
Co-authored-by: Dean Whillier <deanwhillier@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rohitesh Gupta <srkg.gupta@gmail.com>
Co-authored-by: petermcj <petermcj@gmail.com>
Co-authored-by: Peter Johansson <peter.johansson@havochvatten.se>

* [MM-33668] Restore tests to browser-view branch (#1506)

* happy eslint

* wip

* wip

* remove aliases

* almost working tests

* green tests

* Revert "remove aliases"

This reverts commit 803d3695538197407b45e0d8d30dc429b259b7f3.

* add unit test, reconfigure package scripts, make test pass

* [MM-33542] Trigger finder cleanup on pressing close or Escape (#1502)

* [MM-33542] Clear the Finder selection when closing the finder

* Remove listener on close as well

* Run close() on escape as well

* [MM-33607] Remove old badge code, update unreads code (#1503)

* [MM-33607] Remove old badge code, update unreads code

* Fix 2 random lint errors

* fix script naming in circle

* fix check deps

* attempt to fix dependency-check download

* remove check-deps step

Co-authored-by: = <=>
Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>

* Cleanup of BrowserView migration, some bug fixes (#1509)

* 1st round of cleanup

* 2nd round of cleanup

* Set constant for reload-config

* Cleaned up some TODOs

* store daily build to S3 (#1508)

* store daily build to S3

* missing colon

* fix paths

* try to keep folders

* remove unneeded step

* change from arn to bucket name

* keep organization consistent

* fix indentation

* fix indentation x2

Co-authored-by: = <=>

* MM-33551 keep tray state between themes (#1511)

Co-authored-by: = <=>

* Set to version v4.7

Co-authored-by: Guillermo Vayá <guillermo.vaya@mattermost.com>
Co-authored-by: Amy Blais <amy_blais@hotmail.com>
Co-authored-by: Guillermo Vayá <guivaya@gmail.com>
Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>
Co-authored-by: Rodrigo Villablanca <villa061004@gmail.com>
Co-authored-by: Juho Nurminen <juho.nurminen@mattermost.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Nev Angelova <nevy.angelova@gmail.com>
Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MacBook-Pro-2.local>
Co-authored-by: Eugeny Fomin <github.com@jeka.ru>
Co-authored-by: Nathan Bolender <nathan@nathanbolender.com>
Co-authored-by: Dmitriy Danilov <daniloff200@gmail.com>
Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MBP-2.fritz.box>
Co-authored-by: FalseHonesty <skipboman0@gmail.com>
Co-authored-by: William Gathoye <william@gathoye.be>
Co-authored-by: Dean Whillier <deanwhillier@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rohitesh Gupta <srkg.gupta@gmail.com>
Co-authored-by: petermcj <petermcj@gmail.com>
Co-authored-by: Peter Johansson <peter.johansson@havochvatten.se>
2021-03-18 15:51:53 +01:00

533 lines
23 KiB
JavaScript

// Copyright (c) 2015-2016 Yuya Ochiai
// Copyright (c) 2016-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
// TODO: fix test with new settings window
// 'use strict';
// const fs = require('fs');
// const env = require('../../modules/environment');
// const {asyncSleep} = require('../../modules/utils');
// describe('renderer/settings.html', function desc() {
// this.timeout(30000);
// const config = {
// version: 2,
// teams: [{
// name: 'example',
// url: env.mattermostURL,
// order: 0,
// }, {
// name: 'github',
// url: 'https://github.com/',
// order: 1,
// }],
// showTrayIcon: false,
// trayIconTheme: 'light',
// minimizeToTray: false,
// notifications: {
// flashWindow: 0,
// bounceIcon: false,
// bounceIconType: 'informational',
// },
// showUnreadBadge: true,
// useSpellChecker: true,
// enableHardwareAcceleration: true,
// autostart: true,
// darkMode: false,
// };
// beforeEach(async () => {
// fs.writeFileSync(env.configFilePath, JSON.stringify(config));
// await asyncSleep(1000);
// this.app = env.getSpectronApp();
// await this.app.start();
// });
// afterEach(async () => {
// if (this.app && this.app.isRunning()) {
// await this.app.stop();
// }
// });
// describe('Close button', async () => {
// // it.skip('should show index.html when it\'s clicked', async () => {
// // env.addClientCommands(this.app.client);
// // await this.app.client.
// // loadSettingsPage().
// // click('#btnClose').
// // pause(1000);
// // const url = await this.app.client.getUrl();
// // url.should.match(/\/index.html(\?.+)?$/);
// // });
// it('should be disabled when the number of servers is zero', async () => {
// await this.app.stop();
// env.cleanTestConfig();
// await this.app.start();
// await this.app.client.waitUntilWindowLoaded().
// waitForVisible('#newServerModal', 10000).
// click('#cancelNewServerModal');
// let isCloseButtonEnabled = await this.app.client.isEnabled('#btnClose');
// isCloseButtonEnabled.should.equal(false);
// await this.app.client.
// waitForVisible('#newServerModal', true).
// pause(250).
// click('#addNewServer').
// waitForVisible('#newServerModal').
// setValue('#teamNameInput', 'TestTeam').
// pause(100).
// setValue('#teamUrlInput', 'http://example.org').
// click('#saveNewServerModal').
// waitForVisible('#newServerModal', true).
// waitForVisible('#serversSaveIndicator').
// waitForVisible('#serversSaveIndicator', 10000, true); // at least 2500 ms to disappear
// isCloseButtonEnabled = await this.app.client.isEnabled('#btnClose');
// isCloseButtonEnabled.should.equal(true);
// });
// });
// it('should show NewServerModal after all servers are removed', async () => {
// const modalTitleSelector = '.modal-title=Remove Server';
// env.addClientCommands(this.app.client);
// await this.app.client.
// loadSettingsPage().
// click('=Remove').
// waitForVisible(modalTitleSelector).
// element('.modal-dialog').click('.btn=Remove').
// pause(500).
// click('=Remove').
// waitForVisible(modalTitleSelector).
// element('.modal-dialog').click('.btn=Remove').
// pause(500);
// const isModalExisting = await this.app.client.isExisting('#newServerModal');
// isModalExisting.should.be.true;
// });
// // describe('Server list', () => {
// // it.skip('should open the corresponding tab when a server list item is clicked', async () => {
// // env.addClientCommands(this.app.client);
// // await this.app.client.
// // loadSettingsPage().
// // click('h4=example').
// // pause(1000).
// // waitUntilWindowLoaded();
// // let indexURL = await this.app.client.getUrl();
// // indexURL.should.match(/\/index.html(\?.+)?$/);
// // let isView0Visible = await this.app.client.isVisible('#mattermostView0');
// // isView0Visible.should.be.true;
// // let isView1Visible = await this.app.client.isVisible('#mattermostView1');
// // isView1Visible.should.be.false;
// // await this.app.client.
// // loadSettingsPage().
// // click('h4=github').
// // pause(1000).
// // waitUntilWindowLoaded();
// // indexURL = await this.app.client.getUrl();
// // indexURL.should.match(/\/index.html(\?.+)?$/);
// // isView0Visible = await this.app.client.isVisible('#mattermostView0');
// // isView0Visible.should.be.false;
// // isView1Visible = await this.app.client.isVisible('#mattermostView1');
// // isView1Visible.should.be.true;
// // });
// // });
// describe('Options', () => {
// // describe.skip('Hide Menu Bar', () => {
// // it('should appear on win32 or linux', async () => {
// // const expected = (process.platform === 'win32' || process.platform === 'linux');
// // env.addClientCommands(this.app.client);
// // await this.app.client.loadSettingsPage();
// // const existing = await this.app.client.isExisting('#inputHideMenuBar');
// // existing.should.equal(expected);
// // });
// // [true, false].forEach((v) => {
// // env.shouldTest(it, env.isOneOf(['win32', 'linux']))(`should be saved and loaded: ${v}`, async () => {
// // env.addClientCommands(this.app.client);
// // await this.app.client.
// // loadSettingsPage().
// // scroll('#inputHideMenuBar');
// // const isSelected = await this.app.client.isSelected('#inputHideMenuBar');
// // if (isSelected !== v) {
// // await this.app.client.click('#inputHideMenuBar');
// // }
// // await this.app.client.
// // pause(600).
// // click('#btnClose').
// // pause(1000);
// // const savedConfig = JSON.parse(fs.readFileSync(env.configFilePath, 'utf8'));
// // savedConfig.hideMenuBar.should.equal(v);
// // let autoHide = await this.app.browserWindow.isMenuBarAutoHide();
// // autoHide.should.equal(v);
// // // confirm actual behavior
// // await this.app.restart();
// // env.addClientCommands(this.app.client);
// // autoHide = await this.app.browserWindow.isMenuBarAutoHide();
// // autoHide.should.equal(v);
// // await this.app.loadSettingsPage();
// // autoHide = await this.app.client.isSelected('#inputHideMenuBar');
// // autoHide.should.equal(v);
// // });
// // });
// // });
// describe('Start app on login', () => {
// it('should appear on win32 or linux', async () => {
// const expected = (process.platform === 'win32' || process.platform === 'linux');
// env.addClientCommands(this.app.client);
// await this.app.client.loadSettingsPage();
// const existing = await this.app.client.isExisting('#inputAutoStart');
// existing.should.equal(expected);
// });
// });
// describe('Show icon in menu bar / notification area', () => {
// it('should appear on darwin or linux', async () => {
// const expected = (process.platform === 'darwin' || process.platform === 'linux');
// env.addClientCommands(this.app.client);
// await this.app.client.loadSettingsPage();
// const existing = await this.app.client.isExisting('#inputShowTrayIcon');
// existing.should.equal(expected);
// });
// describe('Save tray icon setting on mac', () => {
// env.shouldTest(it, env.isOneOf(['darwin', 'linux']))('should be saved when it\'s selected', async () => {
// env.addClientCommands(this.app.client);
// await this.app.browserWindow.setSize(1024, 768); // Resize the window to click the element
// await this.app.client.
// loadSettingsPage().
// click('#inputShowTrayIcon').
// waitForAppOptionsAutoSaved();
// let config0 = JSON.parse(fs.readFileSync(env.configFilePath, 'utf-8'));
// config0.showTrayIcon.should.true;
// await this.app.client.
// click('#inputShowTrayIcon').
// waitForAppOptionsAutoSaved();
// config0 = JSON.parse(fs.readFileSync(env.configFilePath, 'utf-8'));
// config0.showTrayIcon.should.false;
// });
// });
// describe('Save tray icon theme on linux', () => {
// env.shouldTest(it, process.platform === 'linux')('should be saved when it\'s selected', async () => {
// env.addClientCommands(this.app.client);
// await this.app.browserWindow.setSize(1024, 768); // Resize the window to click the element
// await this.app.client.
// loadSettingsPage().
// click('#inputShowTrayIcon').
// click('input[value="dark"]').
// pause(700); // wait auto-save
// const config0 = JSON.parse(fs.readFileSync(env.configFilePath, 'utf-8'));
// config0.trayIconTheme.should.equal('dark');
// await this.app.client.
// click('input[value="light"]').
// pause(700); // wait auto-save
// const config1 = JSON.parse(fs.readFileSync(env.configFilePath, 'utf-8'));
// config1.trayIconTheme.should.equal('light');
// });
// });
// });
// describe('Leave app running in notification area when application window is closed', () => {
// it('should appear on linux', async () => {
// const expected = (process.platform === 'linux');
// env.addClientCommands(this.app.client);
// await this.app.client.loadSettingsPage();
// const existing = await this.app.client.isExisting('#inputMinimizeToTray');
// existing.should.equal(expected);
// });
// });
// // describe.skip('Toggle window visibility when clicking on the tray icon', () => {
// // it('should appear on win32', async () => {
// // const expected = (process.platform === 'win32');
// // env.addClientCommands(this.app.client);
// // await this.app.client.loadSettingsPage();
// // const existing = await this.app.client.isExisting('#inputToggleWindowOnTrayIconClick');
// // existing.should.equal(expected);
// // });
// // });
// describe('Flash app window and taskbar icon when a new message is received', () => {
// it('should appear on win32 and linux', async () => {
// const expected = (process.platform === 'win32' || process.platform === 'linux');
// env.addClientCommands(this.app.client);
// await this.app.client.loadSettingsPage();
// const existing = await this.app.client.isExisting('#inputflashWindow');
// existing.should.equal(expected);
// });
// });
// describe('Show red badge on taskbar icon to indicate unread messages', () => {
// it('should appear on darwin or win32', async () => {
// const expected = (process.platform === 'darwin' || process.platform === 'win32');
// env.addClientCommands(this.app.client);
// await this.app.client.loadSettingsPage();
// const existing = await this.app.client.isExisting('#inputShowUnreadBadge');
// existing.should.equal(expected);
// });
// });
// describe('Check spelling', () => {
// it('should appear and be selectable', async () => {
// env.addClientCommands(this.app.client);
// await this.app.client.loadSettingsPage();
// const existing = await this.app.client.isExisting('#inputSpellChecker');
// existing.should.equal(true);
// const selected = await this.app.client.isSelected('#inputSpellChecker');
// selected.should.equal(true);
// const windowBounds = await this.app.browserWindow.getBounds();
// const inputLocation = await this.app.client.getLocation('#inputSpellChecker');
// const offset = (inputLocation.y - windowBounds.height) + 100;
// await this.app.client.
// scroll(0, offset).
// click('#inputSpellChecker').
// pause(5000);
// const config1 = JSON.parse(fs.readFileSync(env.configFilePath, 'utf-8'));
// config1.useSpellChecker.should.equal(false);
// });
// });
// describe('Enable GPU hardware acceleration', () => {
// it('should save selected option', async () => {
// const ID_INPUT_ENABLE_HARDWARE_ACCELERATION = '#inputEnableHardwareAcceleration';
// env.addClientCommands(this.app.client);
// await this.app.client.
// loadSettingsPage().
// waitForExist(ID_INPUT_ENABLE_HARDWARE_ACCELERATION, 5000).
// scroll(ID_INPUT_ENABLE_HARDWARE_ACCELERATION);
// const selected = await this.app.client.isSelected(ID_INPUT_ENABLE_HARDWARE_ACCELERATION);
// selected.should.equal(true); // default is true
// await this.app.client.click(ID_INPUT_ENABLE_HARDWARE_ACCELERATION).
// waitForVisible('#appOptionsSaveIndicator', 5000).
// waitForVisible('#appOptionsSaveIndicator', 5000, true); // at least 2500 ms to disappear
// const config0 = JSON.parse(fs.readFileSync(env.configFilePath, 'utf-8'));
// config0.enableHardwareAcceleration.should.equal(false);
// await this.app.client.click(ID_INPUT_ENABLE_HARDWARE_ACCELERATION).
// waitForVisible('#appOptionsSaveIndicator', 5000).
// waitForVisible('#appOptionsSaveIndicator', 5000, true); // at least 2500 ms to disappear
// const config1 = JSON.parse(fs.readFileSync(env.configFilePath, 'utf-8'));
// config1.enableHardwareAcceleration.should.equal(true);
// });
// });
// });
// describe('RemoveServerModal', () => {
// const modalTitleSelector = '.modal-title=Remove Server';
// beforeEach(async () => {
// env.addClientCommands(this.app.client);
// await this.app.client.loadSettingsPage();
// const existing = await this.app.client.isExisting(modalTitleSelector);
// existing.should.be.false;
// const visible = await this.app.client.isVisible(modalTitleSelector);
// visible.should.be.false;
// await this.app.client.
// click('=Remove').
// waitForVisible(modalTitleSelector);
// });
// it('should remove existing team on click Remove', async () => {
// await this.app.client.
// element('.modal-dialog').click('.btn=Remove').
// waitForExist(modalTitleSelector, 5000, true);
// await this.app.client.waitForVisible('#serversSaveIndicator', 10000, true);
// const expectedConfig = JSON.parse(JSON.stringify(config.teams.slice(1)));
// expectedConfig.forEach((value) => {
// value.order--;
// });
// const savedConfig = JSON.parse(fs.readFileSync(env.configFilePath, 'utf8'));
// savedConfig.teams.should.deep.equal(expectedConfig);
// });
// it('should NOT remove existing team on click Cancel', async () => {
// await this.app.client.
// element('.modal-dialog').click('.btn=Cancel').
// waitForExist(modalTitleSelector, 5000, true);
// await this.app.client.waitForVisible('#serversSaveIndicator', 10000, true);
// const savedConfig = JSON.parse(fs.readFileSync(env.configFilePath, 'utf8'));
// savedConfig.teams.should.deep.equal(config.teams);
// });
// it('should disappear on click Close', async () => {
// await this.app.client.
// element('.modal-dialog').click('button.close').
// waitForVisible(modalTitleSelector, 10000, true);
// const existing = await this.app.client.isExisting(modalTitleSelector);
// existing.should.be.false;
// });
// it('should disappear on click background', async () => {
// await this.app.browserWindow.setSize(1024, 768); // Resize the window to click the center of <body>
// await this.app.client.
// click('body').
// waitForVisible(modalTitleSelector, 10000, true);
// const existing = await this.app.client.isExisting(modalTitleSelector);
// existing.should.be.false;
// });
// });
// describe('NewTeamModal', () => {
// beforeEach(() => {
// env.addClientCommands(this.app.client);
// return this.app.client.
// loadSettingsPage().
// click('#addNewServer').
// pause(1000);
// });
// it('should open the new server modal', () => {
// return this.app.client.isExisting('#newServerModal').then((existing) => {
// existing.should.be.true;
// });
// });
// it('should close the window after clicking cancel', () => {
// return this.app.client.
// click('#cancelNewServerModal').
// waitForExist('#newServerModal', 10000, true).
// isExisting('#newServerModal').then((existing) => {
// existing.should.be.false;
// });
// });
// it('should not be valid if no team name has been set', () => {
// return this.app.client.
// click('#saveNewServerModal').
// waitForExist('.has-error #teamNameInput', 10000).
// isExisting('.has-error #teamNameInput').then((existing) => {
// existing.should.be.true;
// });
// });
// it('should not be valid if no server address has been set', () => {
// return this.app.client.
// click('#saveNewServerModal').
// waitForExist('.has-error #teamUrlInput', 10000).
// isExisting('.has-error #teamUrlInput').then((existing) => {
// existing.should.be.true;
// });
// });
// describe('Valid server name', () => {
// beforeEach(() => {
// return this.app.client.
// setValue('#teamNameInput', 'TestTeam').
// click('#saveNewServerModal');
// });
// it('should not be marked invalid', () => {
// return this.app.client.
// isExisting('.has-error #teamNameInput').then((existing) => {
// existing.should.be.false;
// });
// });
// it('should not be possible to click save', () => {
// return this.app.client.
// getAttribute('#saveNewServerModal', 'disabled').then((disabled) => {
// disabled.should.equal('true');
// });
// });
// });
// describe('Valid server url', () => {
// beforeEach(() => {
// return this.app.client.
// setValue('#teamUrlInput', 'http://example.org').
// click('#saveNewServerModal');
// });
// it('should be valid', () => {
// return this.app.client.
// isExisting('.has-error #teamUrlInput').then((existing) => {
// existing.should.be.false;
// });
// });
// it('should not be possible to click save', () => {
// return this.app.client.
// getAttribute('#saveNewServerModal', 'disabled').then((disabled) => {
// disabled.should.equal('true');
// });
// });
// });
// it('should not be valid if an invalid server address has been set', () => {
// return this.app.client.
// setValue('#teamUrlInput', 'superInvalid url').
// click('#saveNewServerModal').
// pause(500).
// isExisting('.has-error #teamUrlInput').then((existing) => {
// existing.should.be.true;
// });
// });
// describe('Valid Team Settings', () => {
// beforeEach(() => {
// return this.app.client.
// setValue('#teamUrlInput', 'http://example.org').
// setValue('#teamNameInput', 'TestTeam');
// });
// it('should be possible to click add', () => {
// return this.app.client.
// getAttribute('#saveNewServerModal', 'disabled').then((disabled) => {
// (disabled === null).should.be.true;
// });
// });
// it('should add the team to the config file', async () => {
// await this.app.client.
// click('#saveNewServerModal').
// waitForVisible('#newServerModal', 10000, true).
// waitForVisible('#serversSaveIndicator', 10000).
// waitForVisible('#serversSaveIndicator', 10000, true). // at least 2500 ms to disappear
// waitUntilWindowLoaded();
// const savedConfig = JSON.parse(fs.readFileSync(env.configFilePath, 'utf8'));
// savedConfig.teams.should.deep.contain({
// name: 'TestTeam',
// url: 'http://example.org',
// order: 2,
// });
// });
// });
// });
// });