aaron/mattermost-desktop
1
0
Fork 0
Code Issues Pull requests Actions 2 Packages Projects Releases Wiki Activity

Fix window.open() looks not working

Browse source 
Intorduced by f8fadcb844
because {show:false} option was inherited from the main window.

https://github.com/electron/electron/blob/v1.4.13/docs/api/window-open.md

Close #450
This commit is contained in:
Yuya Ochiai 2017-02-23 00:37:44 +09:00
parent e2b194ffea
commit 1ff8ec5120
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/browser/components/MattermostView.jsx
View file

@ -72,7 +72,7 @@ const MattermostView = React.createClass({
} }
if (currentURL.host === destURL.host) { if (currentURL.host === destURL.host) {
// New window should disable nodeIntergration. // New window should disable nodeIntergration.
window.open(e.url, 'Mattermost', 'nodeIntegration=no'); window.open(e.url, 'Mattermost', 'nodeIntegration=no,show=yes');
} else { } else {
// if the link is external, use default browser. // if the link is external, use default browser.
shell.openExternal(e.url); shell.openExternal(e.url);