aaron/mattermost-desktop
1
0
Fork 0
Code Issues Pull requests Actions 2 Packages Projects Releases Wiki Activity
2509 commits 1 branch 94 tags 43 MiB
Commit graph

2509 commits

This branch
This branch
All branches
Author SHA1 Message Date
Devin Binnie 4ec938859f
Fix MSI (#2480) 2022-12-17 00:12:04 -05:00
Devin Binnie a089d51d0e
Fix flaky unit test (#2479) 2022-12-16 16:18:16 -05:00
Devin Binnie 7bbcbccbd3
Remove check job and perform check on each build (#2478) 
* Remove check job and perform check on each build

* Missed one

* Fix windows check
 2022-12-16 14:21:46 -05:00
Devin Binnie 29f10f1467
Fixed some unit tests and add test step to run on Windows/Mac builds (#2466) 
* Fixed some unit tests and add test step to run on Windows/Mac builds

* Update failing test

* Fix backlash

* Fix windows run

* Fix Windows again

Co-authored-by: Tasos Boulis <tboulis@hotmail.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
 2022-12-14 17:10:20 -04:00
Claudio Costa e63a293b28
Fix main window disappering on call join (#2472) 2022-12-14 14:23:34 -06:00
Tasos Boulis a1c39d954b
Replace deprecated "gpu-process-crashed" with "child-process-gone" (#2471) 2022-12-14 10:49:12 +02:00
Kaya Zeren 19ad7843d0 Translated using Weblate (Turkish) 
Currently translated at 100.0% (263 of 263 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/tr/
 2022-12-13 09:57:59 -04:00
MArtin Johnson 751246b81c Translated using Weblate (Swedish) 
Currently translated at 100.0% (263 of 263 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/sv/
 2022-12-13 09:57:59 -04:00
Matthew Williams 46cfa2bb51 Translated using Weblate (English (Australia)) 
Currently translated at 100.0% (263 of 263 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/en_AU/
 2022-12-13 09:57:59 -04:00
Tom De Moor 6a3d3fcf32 Translated using Weblate (Dutch) 
Currently translated at 100.0% (263 of 263 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/nl/
 2022-12-13 09:57:59 -04:00
master7 9a563d911f Translated using Weblate (Polish) 
Currently translated at 100.0% (263 of 263 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/pl/
 2022-12-13 09:57:59 -04:00
master7 39be52e339 Translated using Weblate (Polish) 
Currently translated at 100.0% (263 of 263 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/pl/
 2022-12-13 09:57:59 -04:00
Amy Blais f11660acf1
Update feature_request.md (#2459) 2022-12-07 11:02:58 -04:00
cs4p cc1a1ab622
Corrected grammar for unresponsive.dialog.message (#2457) 2022-12-07 14:38:24 +02:00
Tasos Boulis de65cfca4e
Escape server name when used inside regex (#2449) 
* Escape server name when used inside regex

* Move util under common and add test
 2022-12-06 17:29:02 +02:00
Devin Binnie 865fd2522f
Fixed some E2E tests that broke on v5.2 (#2453) 
* Fixing some E2E tests

* Fixed a couple flaky ones

* Fixed some issues on Windows
 2022-12-06 14:40:56 +02:00
Konstantin c37d1ba308 Translated using Weblate (Russian) 
Currently translated at 100.0% (263 of 263 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/ru/
 2022-12-05 12:04:12 -04:00
Kaya Zeren 6281a1d76c Translated using Weblate (Turkish) 
Currently translated at 100.0% (263 of 263 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/tr/
 2022-12-05 12:04:12 -04:00
kaakaa 362469e5e6 Translated using Weblate (Japanese) 
Currently translated at 99.6% (262 of 263 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/ja/
 2022-12-05 12:04:12 -04:00
jprusch ab3309c634 Translated using Weblate (German) 
Currently translated at 100.0% (263 of 263 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/de/
 2022-12-05 12:04:12 -04:00
MArtin Johnson c9a3572858 Translated using Weblate (Swedish) 
Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/sv/
 2022-12-05 12:04:12 -04:00
Tasos Boulis e8754df3c0
Check if url is a plugin url when calculating the window bounds (#2446) 2022-12-05 12:33:40 +02:00
Tasos Boulis 161ae99e94
[MM-47202] - Desktop diagnostics (#2439) 
* Add custom assertion to match object in array (#2358)

* Add custom assertion to match object in array

* Remove test that is not implemented yet

* [MM-48213] Add "Run diagnostics" menu item under Help (#2359)

* Add submenu item that runs diagnostics

* Add custom assertion to match object in array

* Remove test that is not implemented yet

* Add tests

* Add translation

* [MM-47206] Diagnostics steps setup (#2361)

* Add baseline code for diagnostics and their steps

* Fix failing test

* [MM-47206] [MM-48155] Obfuscate logs (#2369)

* Add logging hooks to mask sensitive data

* Add hook that truncates long strings in diagnostics logs

* Add template file for creating steps

* Add readme inside diagnostics

* [MM-48145] Diagnostics step 2 - internet connectivity (#2372)

* Add diagnostics step 2 - internet connectivity check

* Update tests

* [MM-48144] Diagnostics Step - Configure logger (#2390)

* Configure logger

* Move configure logger into step1

* Add file extension to fileName variable

* Diagnostics Step 2: Validate configuration (#2391)

* Resolve conflicts with base branch

* Update test and implement Code review suggestion

* Fix failing test

* [MM-48147]Diagnostics step 3 - server connectivity (#2397)

* Add step3: Check server connectivity by using the /api/v4/system/ping endpoint

* Fix failing tests

* Add better obfuscator functions that mask all types of data (#2399)

* Add better obfuscator functions that mask all types of data(string, array, objects)

* Update tests

* [MM-48148] Add Diagnostics step 4 - session validation (#2398)

* Add diagnostics step 4 - session data validation

* Fix failing tests

* [MM-48152] Add diagnostics step 5 - BrowserWindows checks (#2404)

* Add diagnostics step 5 - browserwindow checks for main window

* Add tests

* [MM-48151] Diagnostics step 6 - Permissions (#2409)

* Add diagnostics step 6 - Permissions check

* Check permissions for microphone ond screen onn mac, windows

* Update tests count in tests

* [MM-48551] Diagnostics step 7 - Performance & Memory (#2410)

* Add diagnostics step 6 - Permissions check

* Check permissions for microphone ond screen onn mac, windows

* Update tests count in tests

* Add diagnostics step 7 - performance and memory

* Fix failing tests

* [MM-48153] Add diagnostics step 8 - Log heuristics (#2418)

* Add diagnostics step 8 - Log heuristics

* Add diagnostics step 9 - config (#2422)

* [MM-48556] Diagnostics Step 10 - Crash reports (#2423)

* Add diagnostics step 9 - config

* Add diagnostics step 10 - include crash reports

* Update tests

* Add diagnostics step 11 - cookies report (#2427)

* [MM-48157] Diagnostics report (#2432)

* Add better logging and pretty print report

* Update last step

* Update log message

* Move log after hooks so that path is masked

* Use correct directory for diagnostics files
 2022-12-02 16:33:42 +02:00
Devin Binnie 567b48516b
Reduced package size by moving most depedencies to devDependencies (#2436) 2022-12-01 16:17:53 -04:00
Tasos Boulis 08e94b9f55
[MM-48574] Fixed issue on windows where in some cases window resize does not work (#2441) 
* Fixed issue on windows where in some cases window resize does not work

* Use silly instead of debug for window resizing functions
 2022-12-01 19:44:47 +02:00
Tasos Boulis cf82058738
Fix debugger for main process (#2440) 2022-12-01 15:31:16 +02:00
Devin Binnie d8baf2ddc9
Extend npm run package:* context deadline to 60m (#2437) 2022-11-30 11:55:42 -05:00
Devin Binnie 0a32030985
[MM-48682] Stop user from opening the servers menu when no servers are configured (#2434) 2022-11-30 11:08:24 -05:00
Pantelis Vratsalis 84ab14eabf
[MM-48685] Fix failing downloads dropdown items tests (#2431) 
* [MM-48685] Fix failing downloads dropdown items tests

* Remove unused styles for Thumbnail
 2022-11-30 17:43:55 +02:00
Pantelis Vratsalis ba50a4cef9
[MM-48733] upgrade playwright (#2430) 2022-11-30 17:43:36 +02:00
Devin Binnie b9758bd679
[MM-48380] Reworked Linux build process to correctly support ARM64 (#2428) 
* [MM-48380] Reworked Linux build process to correctly support ARM64

* Try with ubuntu 18.04

* Why is it backwards

* Revert "Why is it backwards"

This reverts commit 5208fd3fa616a6fe774cca744bb6cd9d3f288a7a.

* Revert "Try with ubuntu 18.04"

This reverts commit e3c0f9e01e5d4b4040f6bb23bbd0fcf6160b92bd.

* :(
 2022-11-30 09:58:42 -05:00
Devin Binnie 3583b3c2b9
Translation update from Weblate (#2424) 
* Translated using Weblate (Spanish)

Currently translated at 99.6% (261 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/es/

* Translated using Weblate (Russian)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/ru/

* Translated using Weblate (Ukrainian)

Currently translated at 57.6% (151 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/uk/

* Translated using Weblate (Japanese)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/ja/

* Added translation using Weblate (Croatian)

* Translated using Weblate (Spanish)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/es/

* Translated using Weblate (Japanese)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/ja/

* Deleted translation using Weblate (Croatian)

* Translated using Weblate (Hungarian)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/hu/

* Translated using Weblate (English (Australia))

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/en_AU/

* Translated using Weblate (Dutch)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/nl/

* Translated using Weblate (Chinese (Simplified))

Currently translated at 14.1% (37 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/zh_Hans/

* Translated using Weblate (Italian)

Currently translated at 5.7% (15 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/it/

* Translated using Weblate (German)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/de/

* Translated using Weblate (Polish)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/pl/

* Translated using Weblate (Russian)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/ru/

* Translated using Weblate (Turkish)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/tr/

* Translated using Weblate (Dutch)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/nl/

* Translated using Weblate (Japanese)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/ja/

Co-authored-by: Angel Mendez Cano <amendez1988@gmail.com>
Co-authored-by: Константин <eleferen@gmail.com>
Co-authored-by: Dmytro Werner <wernerdmytro@gmail.com>
Co-authored-by: kaakaa <stooner.hoe@gmail.com>
Co-authored-by: Milo Ivir <mail@milotype.de>
Co-authored-by: Tom De Moor <tom@controlaltdieliet.be>
Co-authored-by: Tóth Csaba // Online ERP Hungary Kft <csaba.toth@online-erp.hu>
Co-authored-by: Matthew Williams <Matthew.Williams@outlook.com.au>
Co-authored-by: aeomin <lin@aeomin.net>
Co-authored-by: sarz4fun <sarz4fun@yahoo.it>
Co-authored-by: jprusch <rs@schaeferbarthold.de>
Co-authored-by: master7 <marcin.karkosz@rajska.info>
Co-authored-by: Kaya Zeren <kayazeren@gmail.com>
 2022-11-29 09:50:43 -05:00
Pantelis Vratsalis b3aaefb46b
[MM-48383] Upgrade compass-icons (#2421) 2022-11-28 09:14:52 -05:00
Devin Binnie 911ae29623
[MM-48557] Fix AppImage shortcut (#2413) 2022-11-22 11:43:26 -05:00
Devin Binnie 45e7ec95b7
[MM-48079] Fix race condition related to registry loading vs. the welcome screen popup (#2408) 2022-11-22 09:35:46 -05:00
Devin Binnie 3c0d309697
[MM-48380] ARM64 build for Windows/Linux (#2406) 
* Test ARM build for Windows/Linux

* Fix the windows build
 2022-11-21 16:27:16 -05:00
Tasos Boulis b4e21b5c5e
Remove invalid files from downloads list on startup (#2401) 2022-11-18 18:58:32 +02:00
Devin Binnie 9ba36de30e
Bump version to v5.3.0 (#2393) 2022-11-17 09:03:00 -05:00
Tasos Boulis eb31d6f54f
Add debugger for unit tests (#2392) 2022-11-16 19:16:12 +02:00
Weblate (bot) 44931843ff
Translations update from Mattermost Weblate (#2389) 
* Translated using Weblate (Spanish)

Currently translated at 99.6% (261 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/es/

* Translated using Weblate (Russian)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/ru/

* Translated using Weblate (Ukrainian)

Currently translated at 57.6% (151 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/uk/

* Translated using Weblate (Japanese)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/ja/

* Added translation using Weblate (Croatian)

* Translated using Weblate (Spanish)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/es/

* Translated using Weblate (Japanese)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/ja/

* Deleted translation using Weblate (Croatian)

* Translated using Weblate (Hungarian)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/hu/

* Translated using Weblate (English (Australia))

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/en_AU/

* Translated using Weblate (Dutch)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/nl/

* Translated using Weblate (Chinese (Simplified))

Currently translated at 14.1% (37 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/zh_Hans/

* Translated using Weblate (Italian)

Currently translated at 5.7% (15 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/it/

* Translated using Weblate (German)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/de/

* Translated using Weblate (Polish)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/pl/

* Translated using Weblate (Russian)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/ru/

* Translated using Weblate (Turkish)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/tr/

* Translated using Weblate (Dutch)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/nl/

* Translated using Weblate (Japanese)

Currently translated at 100.0% (262 of 262 strings)

Translation: mattermost-languages-shipped/mattermost-desktop
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-desktop/ja/

Co-authored-by: Angel Mendez Cano <amendez1988@gmail.com>
Co-authored-by: Константин <eleferen@gmail.com>
Co-authored-by: Dmytro Werner <wernerdmytro@gmail.com>
Co-authored-by: kaakaa <stooner.hoe@gmail.com>
Co-authored-by: Milo Ivir <mail@milotype.de>
Co-authored-by: Tom De Moor <tom@controlaltdieliet.be>
Co-authored-by: Tóth Csaba // Online ERP Hungary Kft <csaba.toth@online-erp.hu>
Co-authored-by: Matthew Williams <Matthew.Williams@outlook.com.au>
Co-authored-by: aeomin <lin@aeomin.net>
Co-authored-by: sarz4fun <sarz4fun@yahoo.it>
Co-authored-by: jprusch <rs@schaeferbarthold.de>
Co-authored-by: master7 <marcin.karkosz@rajska.info>
Co-authored-by: Kaya Zeren <kayazeren@gmail.com>
 2022-11-16 09:43:42 -05:00
Devin Binnie 791c141aee
[MM-47706] Remove exposure of the ipcRenderer methods in the desktop app and only expose specific endpoints (#2387) 2022-11-16 09:40:18 -05:00
Tasos Boulis 216674a673
Fix issue with windows-focus-assist returning truthy value on older windows versions (#2385) 2022-11-16 11:50:53 +02:00
Tasos Boulis 71f53a477a
Fix release script, it would create rc1 instead of rc.1 (#2383) 
* Dont put dot(.) between rc and number

* Revert "Dont put dot(.) between rc and number"

This reverts commit d9a8837bd0dc18a529d216f76b4f24fe588b63f7.

* Fix missed rc1 in release script
 2022-11-15 12:43:15 +02:00
Tasos Boulis e1f5250c0c
[MM-48080] Update tray icon instantly when the settings change (#2376) 
* Update wording and update tray icon instantly when the settings change

* Add tests

* Include new file
 2022-11-14 21:40:18 +02:00
Devin Binnie 4171774aee
Exclude unnecessary binaries for native modules (#2380) 2022-11-14 14:10:10 -05:00
Tasos Boulis eb8d68d934
Include windows 10 Home instructions in GPO/readme (#2375) 2022-11-11 22:03:29 +02:00
Devin Binnie 0ec3da40ba
[MM-48167] Only grab the last extension from a filename during Save As (#2357) 2022-11-07 09:49:27 -05:00
Claudio Costa 47edeea601
[MM-46993] Implement CallsWidgetWindow (#2265) 
* Initial implementation of CallsWidgetWindow

* Refactor + implement widget resizing logic

* Add tests

* Enable screen sharing

* Channel link

* Add more tests

* Move constants to common file

* Extract boundsDiff into util

* Set background color on initialization

* Fix channel link

* Support installations under a subpath

* Fix path, caching issues and pass title

* [MM-48142] Fix remaining call state issues in main window (#2349)

* Update widget URL to new format

* Slightly bump widget dimensions to account for border

* Fix call state on parent window
 2022-11-07 09:40:13 +01:00
Tasos Boulis c319038704
[MM-48184] Disallow edit/remove server if it is imported from GPO (#2353) 
* Disallow edit/remove server if it is imported from GPO

* Fix width issue of team dropdown
 2022-11-04 17:58:21 +02:00
Tasos Boulis 935cf3a0cc
[MM-48079] Dont show server login when GPO has preconfigured servers (#2346) 
* Show onboarding server screen only when teams.length is 0

* Add tests

* Add more tests

* Fix issue where callback would not re-evaluate variables
 2022-11-04 16:11:56 +02:00